When shibboleth attribute mapping is updated in the UI, the key stored in the configuration repo matches a Java string constant label, i.e. APPLICATION_AUTH_SHIB_ATTRIBUTE_NETID. The VireoUserCredentialsService was attempting to lookup shibboleth keys by the value of the Java constant, i.e. auth.shib.attribute.netid.
When shibboleth attribute mapping is updated in the UI, the key stored in the configuration repo matches a Java string constant label, i.e.
APPLICATION_AUTH_SHIB_ATTRIBUTE_NETID
. The VireoUserCredentialsService was attempting to lookup shibboleth keys by the value of the Java constant, i.e.auth.shib.attribute.netid
.Here is where the Java constants are defined, https://github.com/TAMULib/Vireo/blob/sprint2-staging/src/main/java/org/tdl/vireo/config/constant/ConfigurationName.java#L166.
This PR respects the configuration repo which can be configured in the UI for shibboleth mappings. Also, did the TODOs.