There are a lot of extraneous comments that came along with overriding core dspace-angular components and modules. We will be attempting minimal changes to files copied for overriding to afford easier synchronization when merging from upstream.
Reimplements image gallery theme by customizing collection, community, and search result grid components. The community components required fetching the recent submissions for the community and all custom components required template modifications. The grid component has styles customized to match the image gallery theme.
Instructions for Reviewers
Configure dspace-angular to point to dev environment DSpace REST API with config.dev.yml such as:
*Was unable to only override ItemSearchResultGridElementComponent as customized element would not apply. Had to override the parent component and use a custom selector.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes ESLint validation using yarn lint
[x] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
[ ] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[ ] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[ ] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[ ] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
References
Resolves #6
Description
There are a lot of extraneous comments that came along with overriding core dspace-angular components and modules. We will be attempting minimal changes to files copied for overriding to afford easier synchronization when merging from upstream.
Reimplements image gallery theme by customizing collection, community, and search result grid components. The community components required fetching the recent submissions for the community and all custom components required template modifications. The grid component has styles customized to match the image gallery theme.
Instructions for Reviewers
Configure
dspace-angular
to point to dev environment DSpace REST API withconfig.dev.yml
such as:Switch theme matcher to use UUID in regex until handles are supported:
Navigate to
http//:localhost:4000/collections/befb7166-392b-445b-b907-1f4363bb6dfb http//:localhost:4000/collections/ed211f67-86ad-41ff-9696-fe0e7e17e1cb http//:localhost:4000/collections/d61f515b-8153-4718-9b9d-1ce679c955a0 http//:localhost:4000/collections/c431e202-fc5b-46c8-b188-00901e1e215a http//:localhost:4000/collections/7c2ac72f-fd7a-4f27-b701-eb6e0539a876 http//:localhost:4000/collections/beea4d64-0ff6-4e58-9f7b-489e1d6c6f75 http//:localhost:4000/collections/282ec515-7b66-4492-b4d0-ae66d76f516b http//:localhost:4000/communities/6d433be8-7a28-4dc7-a245-f8dfbb7a513c http//:localhost:4000/collections/282ec515-7b66-4492-b4d0-ae66d76f516b http//:localhost:4000/communities/a3923d8b-249c-4b7d-8459-0c83953f7d8f http//:localhost:4000/collections/7c61a02c-2176-4c5a-9dd8-919353159e91 http//:localhost:4000/communities/a4116d8b-8135-4449-a1b0-3378d5c7ecad
List of changes in this PR:
*Was unable to only override ItemSearchResultGridElementComponent as customized element would not apply. Had to override the parent component and use a custom selector.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn lint
yarn check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.