Add theme override to community list component providing ability to scope to a community and afford expand/collapse all. Replace subcommunities/collection paginated lists with this tree component in a theme community page override. Also, applies override to the image-gallery theme.
During development bugs were discovered in community list service and component that resulted in an upstream PR with same commits in this PR. Unfortunately, some changes in core code were required and have been commented as TAMU customizations.
I have asked @tdonohue if there is interest by the community for the ability to scope the community list (tree) component. He said there is a good chance others would like the feature of a community tree browser at the community level to avoid having to load entire community/collection paths to navigate. This somewhat justifies the core code changes and we may be able to contribute upstream.
Instructions for Reviewers
Configure dspace-angular to point to dev environment DSpace REST API with config.dev.yml such as:
Navigate to Communities & Collection page and to various communities. Expand/collapse the tree individually and using the expand/collapse all buttons.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes ESLint validation using yarn lint
[x] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
[ ] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[ ] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[ ] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[ ] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
References
Resolves #14
Description
Add theme override to community list component providing ability to scope to a community and afford expand/collapse all. Replace subcommunities/collection paginated lists with this tree component in a theme community page override. Also, applies override to the image-gallery theme.
During development bugs were discovered in community list service and component that resulted in an upstream PR with same commits in this PR. Unfortunately, some changes in core code were required and have been commented as TAMU customizations.
I have asked @tdonohue if there is interest by the community for the ability to scope the community list (tree) component. He said there is a good chance others would like the feature of a community tree browser at the community level to avoid having to load entire community/collection paths to navigate. This somewhat justifies the core code changes and we may be able to contribute upstream.
Instructions for Reviewers
Configure
dspace-angularto point to dev environment DSpace REST API withconfig.dev.ymlsuch as:Navigate to Communities & Collection page and to various communities. Expand/collapse the tree individually and using the expand/collapse all buttons.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.