Closed wwelling closed 10 months ago
I'll just note that from the discussion we had my understanding is that the code comments that represent commented out code are from the original base theme. These are copied as-is to keep the difference between the original code as small as possible and less likely to have a merge conflict.
References
Resolves #5
Description
There are a lot of extraneous comments that came along with overriding core dspace-angular components and modules. We will be attempting minimal changes to files copied for overriding to afford easier synchronization when merging from upstream.
Reimplements ESL theme by customizing simple and full item view with link to Energy Systems Laboratory home page.
Instructions for Reviewers
Following instructions described in https://github.com/TAMULib/DSpace/issues/198 and switching out with community and collections under Energy Systems Laboratory.
List of changes in this PR:
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn lint
yarn check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.