Relocate the Descriptors to the standard FOLIO location.
Rename the Descriptors to be a template and bring in the template processing plugins into the POM file.
Change the variable behavior in the Descriptors to be consistent with how standard FOLIO practices use them (${project.version} instead of @project.version@ for example).
There is some concern that we may want @ when looking at spring-way.
Added -XX:MaxRAMPercentage=66.0 for consistency with other projects.
Some projects use a value like 85.0.
I don't have a realistic clue here on what value to use and I am open to not having this environment variable set at all if a proposal to remove it is given.
Add requirements for proper backend deployment to the Descriptors.
This includes environment variables at the memory usage.
Update the application.yml to utilize these environment variables where possible.
Remove shade plugin due to inherent problems and bugs.
The shade plugin was added during another issue this depends on.
After testing and using in this scope, the shade plugin was determined to be problematic.
Errors regarding multiple registrations of AttributeConverter have surfaced (in mod-workflow).
This is a bug between the shade plugin and hibernate as far as I can tell from my online research.
The default application.yml is missing the spring.datasource.platform.
Not having this works fine for h2.
Not having this breaks for postgresql.
resolves #219 (in theory)
Relocate the Descriptors to the standard FOLIO location.
Rename the Descriptors to be a template and bring in the template processing plugins into the POM file.
Change the variable behavior in the Descriptors to be consistent with how standard FOLIO practices use them (
${project.version}
instead of@project.version@
for example). There is some concern that we may want@
when looking at spring-way.Added
-XX:MaxRAMPercentage=66.0
for consistency with other projects. Some projects use a value like 85.0. I don't have a realistic clue here on what value to use and I am open to not having this environment variable set at all if a proposal to remove it is given.Add requirements for proper backend deployment to the Descriptors. This includes environment variables at the memory usage. Update the
application.yml
to utilize these environment variables where possible.Remove shade plugin due to inherent problems and bugs. The shade plugin was added during another issue this depends on. After testing and using in this scope, the shade plugin was determined to be problematic. Errors regarding multiple registrations of
AttributeConverter
have surfaced (in mod-workflow). This is a bug between the shade plugin and hibernate as far as I can tell from my online research.The default
application.yml
is missing thespring.datasource.platform
. Not having this works fine for h2. Not having this breaks for postgresql.see: https://dev.folio.org/guides/module-descriptor/ see: https://dev.folio.org/guides/install-backend-module/