TAMULib / scholars-discovery

MIT License
1 stars 1 forks source link

Organization total persons not aligning with total persons in academic age group visualization #418

Open wwelling opened 1 month ago

wwelling commented 1 month ago

The College of Engineering has 843.

https://scholars.library.tamu.edu/vivo/display/n8627320c/Organizations/View%20All?People.page=1&People.size=5#de8b68f4-6b87-4e08-8632-aee9c927ecc0

The academic age group visualization researchers in all age group total should be a close match to that. Should be verifiable with additional query.

Is currently 29 total. :/

https://scholars.library.tamu.edu/vivo/data-and-analytics/Publications%20by%20Academic%20Age%20Group?facets=positions,selectedPublicationVenue,selectedPublicationPublisher&positions.type=STRING&positions.pageSize=10&positions.pageNumber=1&positions.sort=COUNT,DESC&selectedPublicationVenue.type=STRING&selectedPublicationVenue.pageSize=10&selectedPublicationVenue.pageNumber=1&selectedPublicationVenue.sort=COUNT,DESC&selectedPublicationPublisher.type=STRING&selectedPublicationPublisher.pageSize=10&selectedPublicationPublisher.pageNumber=1&selectedPublicationPublisher.sort=COUNT,DESC&expanded=Position%2520Titles,Journal%2520Titles,Publishers&class.filter=Person&class.opKey=EQUALS&filters=class&selectedOrganizations=n8627320c

wwelling commented 1 month ago

https://github.com/TAMULib/scholars-angular/blob/tamu-main/src/app/%2Bdata-and-analytics/academic-age-group/academic-age-group.component.ts#L185

The results and graphs are accurate to the persons position organization excluding the default organization which has no filter for persons included.

wwelling commented 1 month ago

Related to https://github.com/TAMULib/scholars-discovery/issues/15

wwelling commented 1 month ago

Adding a field on person for organizations that includes position organization and recursively organizations within will provide what is required to resolve.

Updating the filter to that field will resolve this problem.

      if (this.organization.id !== this.defaultId && !!this.organization.name) {
        additionalFilters.push({
          field: 'organizations',
          value: this.organization.name,
          opKey: OpKey.EQUALS
        });
      }
wwelling commented 1 month ago

An organization field already exists and does not appear to be used yet.

https://github.com/TAMULib/scholars-discovery/blob/tamu-main/src/main/resources/templates/sparql/person/organization.sparql

wwelling commented 1 month ago

Here is the sparql that was getting the list of people of an organization where the number of people was being rendered next to the organization name.

https://github.com/TAMULib/scholars-discovery/blob/tamu-main/src/main/resources/templates/sparql/organization/people.sparql

We could try to include all persons of an organization and all sub organizations within a single organization solr document field. Which would provide a solution to #15.