TAMULib / weaver-components

Custom Web Components for the Weaver UI
MIT License
0 stars 1 forks source link

Weaver components should switch to ESLint #462

Open jeremythuff opened 3 years ago

jeremythuff commented 3 years ago

Currently, we are using TSLint, which has been deprecated. ESLint should be used instead.

This will require introducing a configuration for ESLint which mirrors the settings we have configured for TSLint. In addition to this, our linting process is implicated in our build process and this will need to be switched over to ESLint.

This will require the removal of codelyzer and angular-tslint-rules.

Additionally there are tslint comments throughout code which will need to be updated to eslint style comments.

A possible aid to this task could be using the angular CLI to create a fresh project and observe the linting setup within that new project.

References:

kaladay commented 2 years ago

As of https://github.com/TAMULib/tamu-library-components/issues/429 (PR = https://github.com/TAMULib/tamu-library-components/pull/430), the TSLint is removed. However, the implementation provided there still utilizes TSLint functionality via wrappers. I suggest that this issue be re-interpretated as to remove the remaining TSLint code and use ESLint properly.

Secondly, there is a problem with ESLint that maay need to be solved:

TypeError: message.trim is not a function

This is an upstream problem that needs to be fixed. I will report this bug upsream if it isn't already reported. With any luck this will eventually be fixed upstream.