Recomendations for update to alta_veesta.ino

TANC-security / keypad-firmware

ECP keypad implementation for Arduino/AVR

https://alarmtool.com/

GNU Lesser General Public License v2.1

39 stars 8 forks source link

Recomendations for update to alta_veesta.ino #1

Open ghost opened 6 years ago

ghost commented 6 years ago

Attached file is a recomended update to the INO from the May 21st file posted.

Added (F to every Seriel.print strings possible.
Added a #ifdef DEBUG around the print unkown char code as that is really only needed in debug and not required for normal operations that I can see and just clutters the console.

alta_veesta.zip

markkimsal commented 6 years ago

Thanks for the F() statements, but I won't be able to merge them for a while.

The unknown chars is a borderline error condition. Yeah, they're not useful, but they represent a flaw in the system that I feel should be known whether or not you are debugging. They shouldn't be cluttering up the console too much, but also they are json so a script can easily ignore type=='unknown'