search

TAO-Dataset / tao

Code for downloading and using the TAO dataset: http://taodataset.org/
Other
194 stars 32 forks source link

Why is it a bug? #21

Closed fanq15 closed 4 years ago

fanq15 commented 4 years ago

https://github.com/TAO-Dataset/tao/blob/4b191605f2ffbdbe4aea9f66ce02f7dec5e616e9/tao/toolkit/tao/tao.py#L102

achalddave commented 4 years ago

Hm, could you expand? Did this assertion fire for you when evaluating? This check should never fire.

Background: In TAO, we merged a small number of LVIS categories together as they have very similar definitions and labelers were not able to tell them apart. I will document this in the evaluation soon. The if statement you linked just ensures that this merging is properly indicated in the json file.

fanq15 commented 4 years ago

I use TAO api to process my own dataset. Should I ignore it on my own dataset if I do not need to merge categories?

achalddave commented 4 years ago

Yup! Feel free to delete that line. You can also delete / comment out these lines: https://github.com/TAO-Dataset/tao/blob/4b191605f2ffbdbe4aea9f66ce02f7dec5e616e9/tao/toolkit/tao/tao.py#L113-L116

Let me know if you run into other problems by filing a new issue! The TAO api should be usable for other datasets, but there are likely some small issues you can run into. One major note is that the TAO api expects a federated dataset, so make sure to set up "neg_category_ids" and "not_exhaustive_category_ids" correctly in your annotations JSON.