search

TAPevents / tap-i18n

A comprehensive internationalization solution for Meteor.
MIT License
330 stars 85 forks source link

Compatibility Meteor 3.0.1 #240

Open martijnbar opened 1 month ago

martijnbar commented 1 month ago

It seems there are compatibility issues with Meteor version 3.0.1. I get the following error when trying to add the tap-i18n package (v.2.0.1) to my meteor 3.0.1 application

error: Conflict: Constraint webapp@1.10.1 is not satisfied by webapp 2.0.0. Constraints on package "webapp":

fjmr68 commented 3 weeks ago

Hi, I have the same problem. Any idea to fix it?

Marcel-Tronco commented 3 weeks ago

Hi, same same here. I just tried running the package with pinning the webapp version to 2.0.0 locally. It worked for me (in a setup with Blaze), but I can't verify that it works with other setups as there's no tests integrated in the repo.

theosp commented 3 weeks ago

The pinning was on the package.js level? If so, I'd appreciate a PR.

On Mon, 19 Aug 2024 at 9:14 PM, Marcel-Tronco @.***> wrote:

Hi, same same here. I just tried running the package with pinning the webapp version to 2.0.0 locally. It worked for me (in a setup with Blaze), but I can't verify that it works with other setups as there's no tests integrated in the repo.

— Reply to this email directly, view it on GitHub https://github.com/TAPevents/tap-i18n/issues/240#issuecomment-2296685008, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABSVBS7OQT2GPR4OXE6HYLZSH4TZAVCNFSM6AAAAABMBXOIBOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJWGY4DKMBQHA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Marcel-Tronco commented 3 weeks ago

No, actually I pinned it in the .versions-file. The docs don't say to much about versioning in packages. They don't mention the .version-file anymore, so maybe it's just a compatibility feature for old packages. Anyways I just tried to delete the file altogether, because as you implied, nowadays versions in a package probably should be pinned in the package.js: and it still works.

Marcel-Tronco commented 2 weeks ago

The changelog says:

The constraint solver no longer leaves a versions.json file in your packages source directories; when publishing a package that is not inside an app, it will leave a .versions file (with the same format as .meteor/versions) which you should check into source control.

That's explaining why local development made it seem superfluous anyways.