TASBE / TASBEFlowAnalytics

Flow cytometry unit conversion and analytics
Other
7 stars 8 forks source link

Double-computing of peaks in beads_to_ERF_model #259

Open jakebeal opened 6 years ago

jakebeal commented 6 years ago

The beads_to_ERF_model.m file computes peaks twice, once for the designated ERF channel and once for all channels including the designated ERF channel. This redundancy makes our code more vulnerable, and should be refactored out by having just the all-channels computation, but treating some aspects of it specially.

coverney commented 6 years ago

What aspects should be treated specially?

jakebeal commented 6 years ago

Off the top of my head, I'm not sure --- this is a place to dig through the code. The guiding principle, however, is this:

In the future, we might want to do more with the other channels, such as compare their peaks also in certifying identity between color models (if we aren't already; I don't remember).