search

TASEmulators / BizHawk

BizHawk is a multi-system emulator written in C#. BizHawk provides nice features for casual gamers such as full screen, and joypad support in addition to full rerecording and debugging tools for all system cores.
http://tasvideos.org/BizHawk.html
Other
2.2k stars 384 forks source link

PCE/SGX 1941 BROKEN LATEST DEV BUILD APPVEYOR #1203

Closed ghost closed 4 years ago

ghost commented 6 years ago

Since bizhawk 2.2.2 2 pce games i noticed issues with were fixed but one is now broken

1941 as soon as you start level one the clouds draw funny.

This is not broken in earlier builds.

ghost commented 6 years ago

for anyone else with this problem as a for now solution i went and downloaded the latest mednafen liberto core for super grafx and set bizhawk to load all pce/sgx roms with this core.

ghost commented 6 years ago

waterbox mednafen?!?!?

alyosha-tas commented 6 years ago

I won’t be able to fix this so unassigning myself.

We need someone to either take over or kill off the PCE core.

ghost commented 6 years ago

But it was working in the previous release

Get Outlook for Androidhttps://aka.ms/ghei36

From: alyosha-tas notifications@github.com Sent: Thursday, September 13, 2018 7:23:38 PM To: TASVideos/BizHawk Cc: jjfmz42015; Author Subject: Re: [TASVideos/BizHawk] PCE/SGX 1941 BROKEN LATEST DEV BUILD APPVEYOR (#1203)

I won’t be able to fix this so unassigning myself.

We need someone to either take over or kill off the PCE core.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/TASVideos/BizHawk/issues/1203#issuecomment-421182958, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ARgQZYt1w3njlR3JVJ7fVTpMOe6TAyJeks5uauj6gaJpZM4USjqd.

vadosnaprimer commented 6 years ago

Just bisect guys!

Asnivor commented 6 years ago

Hmm, bisect really is great. I should use this more often :)

Anyway, this is the breaking commit: https://github.com/TASVideos/BizHawk/commit/aa7cee1bb7d123f5ed9c136554bb8fae7d9d9b37

However, at this time I haven't got a clue where to start in trying to fix it....

alyosha-tas commented 6 years ago

unfirtunately I don’t really remember what most of that commit is doing. Sometimes I think that the PCE core works just by chance.

You can uncomment all the console.write stuff though and it should give you some decent diagnostic information. Usually the issues that pop up are related to one of those variables changing.

Asnivor commented 6 years ago

So un-commenting those in VDC.Render.cs does nothing - its a supergrafx game rather than turbografx. So the issue is going to be related to the commit changes made in VDC.cs and/or VPC.cs

I can p*ss about changing things until something may or may not work, but ultimately I don't understand enough about the emulated tech itself at this point. If this commit actually fixed problems in other games, then I will almost certainly introduce regressions that I have no idea how to fix.

I'll probably bow out here now...

Asnivor commented 6 years ago

@jjfmz42015 I believe this should be fixed now. Can you please test in the latest dev build and let us know?

https://ci.appveyor.com/project/zeromus/bizhawk-udexo/build/artifacts

nattthebear commented 4 years ago

Reopen if this still happens on the nyma core