TASEmulators / BizHawk

BizHawk is a multi-system emulator written in C#. BizHawk provides nice features for casual gamers such as full screen, and joypad support in addition to full rerecording and debugging tools for all system cores.
http://tasvideos.org/BizHawk.html
Other
2.2k stars 385 forks source link

Importing a bk2 into TAStudio was recently broken #2347

Closed RetroEdit closed 4 years ago

RetroEdit commented 4 years ago

For one minute, movies in Uzebox seemed to work fine. We seemed to have finally escaped the regression that plagued 2.4.1 and 2.4.2. But then 01093860493b252e3707cfc99c775b92e6ea1302 introduced another problem (may not be specific to Uzebox).

Repro steps:

Here's the call stack.

>   BizHawk.Client.Common.dll!BizHawk.Client.Common.TasMovie.Attach(BizHawk.Emulation.Common.IEmulator emulator) Line 53    C#
    BizHawk.Client.Common.dll!BizHawk.Client.Common.MovieSession.RunQueuedMovie(bool recordMode, BizHawk.Emulation.Common.IEmulator emulator) Line 235  C#
    EmuHawk.exe!BizHawk.Client.EmuHawk.MainForm.StartNewMovie(BizHawk.Client.Common.IMovie movie, bool record) Line 40  C#
    EmuHawk.exe!BizHawk.Client.EmuHawk.TAStudio.StartNewMovieWrapper(BizHawk.Client.Common.ITasMovie movie) Line 657    C#
    EmuHawk.exe!BizHawk.Client.EmuHawk.TAStudio.Engage() Line 210   C#
    EmuHawk.exe!BizHawk.Client.EmuHawk.TAStudio.Tastudio_Load(object sender, System.EventArgs e) Line 145   C#

Our DTC9 peeps would probably appreciate if this was fixed in time for the 2.5 release.

RetroEdit commented 4 years ago

Okay, this is not Uzebox-specific. I just tried a GBA game.

RetroEdit commented 4 years ago

If you open TAStudio first and then open a .bk2, it imports the .bk2 fine. So it's specifically importing after already having a traditional MovieSession open for some reason.

RetroEdit commented 4 years ago

Fixed by 9db5ee2e7b65eb273729e99fb3727e6725103606.