search

TASEmulators / BizHawk

BizHawk is a multi-system emulator written in C#. BizHawk provides nice features for casual gamers such as full screen, and joypad support in addition to full rerecording and debugging tools for all system cores.
http://tasvideos.org/BizHawk.html
Other
2.14k stars 380 forks source link

GBHawk: Totsugeki! Ponkotsu Tank desynchronization #2406

Closed Reinc01 closed 3 years ago

Reinc01 commented 4 years ago

I recorded an input movie where I play through the arena mode of Totsugeki! Ponkotsu Tank (Japanese version of Trax) where I play through all 12 arenas and then lose on purpose. The input movie instead desynchs in random parts.

Totsugeki! Ponkotsu Tank - arena mode.zip

alyosha-tas commented 4 years ago

I found a variable missing from the savestate that could be the cause here. please re-test in dev build.

adelikat commented 3 years ago

No response from reporter, marking this as fixed

Reinc01 commented 3 years ago

No response because I don't have the dev version, so I can't check if the fix worked or not.

zeromus commented 3 years ago

The typical response to "Found your bug probably. Please test it." in cases where you don't know how test it is "how do I test it", not ""

YoshiRulz commented 3 years ago

Instructions for getting a dev build are in the readme.

Reinc01 commented 3 years ago

It's not a "probably a bug", it's a bug. I tried playing the same input movie in the lastest dev build, and the desyncs still happen.

zeromus commented 3 years ago

Good thing I didn't say it was probably a bug but rather that it was a bug that had probably been found. After alyosha's fix your movie is not guaranteed to sync. In fact it's likely that it won't. When a bug like that is fixed you need to repair the movie. After it's repaired, it should be stable.

RetroEdit commented 3 years ago

To clarify, zeromus is saying you need to recreate the movie in the dev build to show that there's actually inconsistent savestates in the dev build.

Just playing back the original movie shows that the one particular movie doesn't work, it doesn't mean there's a desync with savestates necessarily unless you specifically show that.

Or at least, I assume you used savestates in the process of creating the original movie?

Reinc01 commented 3 years ago

The arena mode movie starts with power-on, if that's what you are asking about. I did use save states during recording.

RetroEdit commented 3 years ago

Yeah, then merely playing back the old movie just shows that the old movie desyncs, not that a newly-created movie would still desync (because the probable cause of the desync was savestates, not emulation).

Reinc01 commented 3 years ago

I've recorded a new movie with the most recent dev build, and desynchs still happen in the arena mode.

zeromus commented 3 years ago

I just did a quick run with the tastudio integrity checker and found a discrepancy in the very 0th frame at what seems to be master_audio_clock in the audio component. I don't think that's a real issue but really it probably has more to do with the integrity checker trying to turbo and the audio synthesis getting skipped, but i figured I'd write it here anyway.

alyosha-tas commented 3 years ago

Weird, I'll look into it.

alyosha-tas commented 3 years ago

@Reinc01 Does the US version also desync? can you provide more exact reproduction steps?

Reinc01 commented 3 years ago

I did not check the US version. You can see the desynchronization happening in the input movie that's attached to my first message. Reproduction steps:

  1. Record movie from power-on.
  2. Play arena mode.
  3. Play through at least one arena (while using save states)
  4. Play movie, see desynch.
alyosha-tas commented 3 years ago

Hmmm,

Does it desync if you try to do the same thing in Gambatte?

Also while I'm thinking of it can you please re-test this issue you reported a while ago:

Litti's Summer Sports keeps crashing/freezing at the beginning of the first weightlifting event.

Reinc01 commented 3 years ago

There is no desynchronization when I record in Gambatte. Litti's Summer Sports still crashes at the same spot.

alyosha-tas commented 3 years ago

autofire was used in the .bk2 here, so I'm closing this one too.

@Reinc01 please retest in 2.6.2