search

TASEmulators / BizHawk

BizHawk is a multi-system emulator written in C#. BizHawk provides nice features for casual gamers such as full screen, and joypad support in addition to full rerecording and debugging tools for all system cores.
http://tasvideos.org/BizHawk.html
Other
2.2k stars 385 forks source link

Movie "record from now" desyncs with savestates #2438

Closed Yave-Yu closed 3 years ago

Yave-Yu commented 4 years ago

BizHawk 2.5.1 Stable I recorded final boss fighting bk2 movie of Hokuto no Ken, and replay it, it desyncs. I tried several times, it always desync. This is bk2 movie: Hokuto no Ken Final Boss Fighting.zip ROM used Hokuto no Ken (J) [!].nes in GoodNES 3.23b pack.

adelikat commented 4 years ago

I did some digging on this and this ROM maps to the CNROM mapper. I double checked and we are saving all the mapper variables we need to do, so it isn't a simple case of missing a value.

a .bk2 that is already in a desynced state, there isn't really anything we can do. Can you reproduce this in a way that involves creating a movie that consistently produces this problem?

Yave-Yu commented 4 years ago

Well, try to record "now" movie from here? Hokuto no Ken.NesHawk.QuickSave1.State.zip

Yave-Yu commented 3 years ago

2.5.2 still have this problem... now I need 2.4.2 version, that works fine.

Yave-Yu commented 3 years ago

Seems ce0ccd0cf has fixed this issue, nice.

YoshiRulz commented 3 years ago

Was probably 7865fe298

Yave-Yu commented 3 years ago

Well, seems the issue happened again. This time, I played Wolverine, recorded final boss battle, then replay it, desynced. So I post the savestate here, you can record "now" from here and find what it happens. Wolverine.NesHawk.QuickSave1.State.zip

ROM: Wolverine (U) [!].nes SHA1: 72279226339938A684292BF17BBAEEF78B67C788

adelikat commented 3 years ago

Did it happen on latest master? or again on the latest release?

Yave-Yu commented 3 years ago

Did it happen on latest master? or again on the latest release?

~~Well, I tested again, and I find exactly reason: Input Method If I use DirectInput+XInput, it works fine; if OpenTK, it will desync (appearence the issue happens in recording).~~ No, this time I use DirectInput+XInput, on another game 2-in-1- Yuu Yuu + Dragon Ball Z (Multi)[Unknown][!].nes (not original game because emulator couldn't use barcode), and recorded its final battle, then replay, desynced... I don't know why BizHawk couldn't record "now" (and "SaveRam") movie normally since 2.5, 2.4.2 is very stable on recording. ROM SHA1: F4FACF40F0B3DD7D87CD640DA0F0B7FD2B40D33A 2-in-1 - Yuu Yuu + Dragon Ball Z [p1][!].NesHawk.QuickSave1.State.zip

Yave-Yu commented 3 years ago

I'm sorry I'm not describe it clearly before. Record from now desyncs with savestates, and not always happen. Please recheck it.

adelikat commented 3 years ago

Have you tried with BIzHawk 2.6?

Yave-Yu commented 3 years ago

OK, I now try 2.6 stable, choose Wolverine and beat final boss again. ROM: Wolverine (U) [!].nes Wolverine.NesHawk.QuickSave1.State.zip

In recording, I blowed the final boss down! (F1100) Recording

OK, stop recording and replay it, 54 rerecord counts. No, at F700~ this guy just hit nothing and the final boss won't be blowed down. Playing

Seems the issue still present.

alyosha-tas commented 3 years ago

Initial movie used autofire, but this issue seems to have evolved considerably since it was posted.

@Yave-Yu please re-test in dev build or 2.6.2

zeromus commented 3 years ago

I'm hoping whatever this is is what's breaking record from now on psx....

Yave-Yu commented 3 years ago

2.6.2 Stable Seems my old Wolverine savestate and movie are no longer usable, so I choose another game Bio Miracle Bokutte Upa. Record from now, from stage 1-1's beginning (when graphics were complete loaded). 1 I get hurt and die then load state continually, and finally went here at F4465. 2 Rerecord count: 58, now replay it... 3 Same result! Seems this issue fixed?

alyosha-tas commented 3 years ago

Ok thanks for testing. I had done some 'record from now' testing myself and didn't notice any issues.

I think PSX has it's own unrelated issues.

closing.