TASEmulators / BizHawk

BizHawk is a multi-system emulator written in C#. BizHawk provides nice features for casual gamers such as full screen, and joypad support in addition to full rerecording and debugging tools for all system cores.
http://tasvideos.org/BizHawk.html
Other
2.19k stars 383 forks source link

`.cgp` shader from Libretro's common-shaders fails to load #2727

Closed ghost closed 3 years ago

ghost commented 3 years ago

.CGP common shaders all crash.

Or am I using the wrong shaders?

ghost commented 3 years ago

the included hq2x doesnt work properly easy to notice when used and compare to the emulator cores being used running hq2x outside of bizhawk

zeromus commented 3 years ago

cant compare without screenshots but I guess I don't care, either

YoshiRulz commented 3 years ago

CNR. Please use the issue template when reporting crashes, you haven't given us anything to go off of.

ghost commented 3 years ago

okj so bizhawk documents it can use the common shaders.

it is able to load the bundled cgp file for hq2x. however if you go on github and download the latest common shaders pack bizhawk fails to load them. I can not find a version of bizhawk that wont fail.

if you try it instant error.

no looking for the lost city of atlantis here. the feature does not work period.

YoshiRulz commented 3 years ago

Repro'd with this shader at 6dbe73d30. No promises that it'll get fixed.

edit: also it doesn't cause a crash, just an error dialog; and I tried both D3D and OpenGL

vadosnaprimer commented 3 years ago

Making libretro shaders work would be insanely huge!

ghost commented 3 years ago

It just looked like a broken feature so i reported it.

zeromus commented 3 years ago

Which "documents" say it can use the common shaders? It should say it can use the common shaders, roughly, but that each shader will require adapting. Bizhawk cannot use retroarch shaders verbatim because they are generally a broken mess. This issue can be closed once the docs are fixed. We ALREADY have an hq2x shader PORTED FROM LIBRETRO so I have no idea why OP would be trying this, he seems generally very confused to me. Probably other display options are making the screen look different from another emulator and he blames it on our hq2x

ghost commented 3 years ago

Which "documents" say it can use the common shaders? It should say it can use the common shaders, roughly, but that each shader will require adapting. Bizhawk cannot use retroarch shaders verbatim because they are generally a broken mess. This issue can be closed once the docs are fixed. We ALREADY have an hq2x shader PORTED FROM LIBRETRO so I have no idea why OP would be trying this, he seems generally very confused to me.

You are an asshole. Close it and keep your shit mess of a front end