TASEmulators / BizHawk

BizHawk is a multi-system emulator written in C#. BizHawk provides nice features for casual gamers such as full screen, and joypad support in addition to full rerecording and debugging tools for all system cores.
http://tasvideos.org/BizHawk.html
Other
2.2k stars 385 forks source link

Something with Display configuration in Nymashock isnt quite right #3409

Closed TizianoMattei closed 2 years ago

TizianoMattei commented 2 years ago

Summary

During usage of the new core, i've come across some weirdness regarding display settings, however this was mostly reported to me by other users as we were collaborating on stuff on other PSX games, as i dont usually try anything different than "Use system's recommendation"

Repro

  1. Open a PSX game in nymashock
  2. Config
  3. Display
  4. Use display settings that arent "system recommendation", like 1:1 pixel size, unchecking "mantain aspect ratio", or "expand pixels by integers".

Output

The following are side to side comparisons of the same settings, on a fresh bizhawk config.ini file, between octoshock and nymashock

1 2 3

There's also stretching whenever one tries to dump footage from the emulator, if one doesnt check first "capture OSD" option. For example, following any guide here: https://tasvideos.org/Forum/Topics/22681, like using this -vcodec libx264 -pix_fmt yuv420p -crf 20 -acodec aac as custom command on ffmpeg in bizhawk, depending on wether or not the user has checked the capture OSD option, gives these 2 different results (with the same display settings as shown): 4

Host env.

Bizhawk 2.8, Win10 22H2, AMD Cpu, Nvidia GPU

CasualPokePlayer commented 2 years ago

This is expected behavior. Disabling aspect ratio correction will make the core output something similar to "hardcore debug mode" of Octoshock, which won't look pretty but that is what the core is outputting.

TizianoMattei commented 2 years ago

I see. But is the avi dump supposed to be that stretched when recording movies without the "capture OSD" thicked? That's with default settings, i've seen quite a few users outside TAS usage that have no idea why only their footage out of bizhawk looks so distorted and have no idea how to solve it

Also does Expand pixels by integers only still disables aspect ratio correction aswell? Emulated game gets visually distorded with that too, without needing to unthick mantain aspect ratio

CasualPokePlayer commented 2 years ago

Yes, if you don't tick capture OSD the AVI dumper goes to the raw video buffer instead of what's output by the DisplayManager (which does aspect ratio correction here).

Expand pixels by integer only would probably cause distortion. It would be fine if square pixels were actually outputed on console, but that is not the case.

TizianoMattei commented 2 years ago

That makes sense, thanks for the explanation, if anything i would at least suggest to make default "capture osd", then