search

TASEmulators / BizHawk

BizHawk is a multi-system emulator written in C#. BizHawk provides nice features for casual gamers such as full screen, and joypad support in addition to full rerecording and debugging tools for all system cores.
http://tasvideos.org/BizHawk.html
Other
2.19k stars 384 forks source link

TAStudio marker edit dialogue box spawns in bad locations #3714

Open RetroEdit opened 1 year ago

RetroEdit commented 1 year ago

In BizHawk 2.9.1, creating a marker (via double clicking or the 'Add marker with text' icon) will spawn the marker edit dialogue box where the mouse cursor is.

This behavior doesn't make sense to me, and it's often in an inconvenient location. By contrast, the 'Edit Marker Text' icon always places the edit dialogue consistently and conveniently in the center of the TAStudio window, but it can't be used to create new markers.

Preferred behavior: all methods of editing marker text place the dialogue box in the same location.

Host env.

RetroEdit commented 1 year ago

Oh wait, I just realized I reported this a while ago, and it was resolved as "won't fix": #2369

I have some new context here of inconsistent behavior, but I won't be offended if this also resolves the same way.

Morilli commented 4 months ago

Ah least the double click behavior was explicitly coded to spawn the dialog box on the cursor location: https://github.com/TASEmulators/BizHawk/blob/4f144c74d47021018bc3252393db8685d98d58c7/src/BizHawk.Client.EmuHawk/tools/TAStudio/MarkerControl.cs#L234-L240

So I wanna say this is intended behavior? I personally don't find this bothersome at all, but arguably the inconsistency in behavior doesn't really make sense.

YoshiRulz commented 4 months ago

IMO all modal dialogs should appear centred on their parent window, no exceptions.

vadosnaprimer commented 4 months ago

IMO all modal dialogs should appear in centred on their parent window, no exceptions.

How many tastudio markers did you create in your life?

Morilli commented 2 months ago

it's often in an inconvenient location

Could you elaborate on this? If you move the mouse to click on an icon and the shown dialog box appears directly under the mouse, where's the issue in that?

RetroEdit commented 1 month ago

Late reply (somehow I was unsubscribed from this GitHub issue), but I believe there was an issue of it getting offset when the TAStudio window is near the edge of the screen. I also recall some situations where it would spawn the dialog box in the place it was previously instead of relative to the current window.

In some cursory testing in 2.9.1, I'm not observing either of these two issues (which is weird: maybe they show up only in edge cases or I got confused when filing this issue?), though I do think if the standard is going to be mouse cursor centered, that should extend to the "edit cursor text" button.