[Amiga core] Disk switching not recorded properly / playback desynch at disk switch

TASEmulators / BizHawk

BizHawk is a multi-system emulator written in C#. BizHawk provides nice features for casual gamers such as full screen, and joypad support in addition to full rerecording and debugging tools for all system cores.

http://tasvideos.org/BizHawk.html

Other

2.2k stars 384 forks source link

[Amiga core] Disk switching not recorded properly / playback desynch at disk switch #3995

Closed ScHlAuChii closed 1 month ago

ScHlAuChii commented 3 months ago

Summary

Switching disks is not recorded properly

Repro

Pick a multi disk game (Aladdin - 3 disks in this example)
Create a XML with the Multi DIsk Bundler
Record a movie and switch the disks when its requested - all works fine.
Play back the movie and it desynchs as the disk switching isnt working.

Host env.

Recent Dev build

vadosnaprimer commented 3 months ago

Game info

cb37d0ffe39cb93843fd5585241ddf36ea13ea19  "Aladdin (AGA)_Disk1.adf"
a3997381c4e82d97c941adbdc4c5d5e94b7e5019  "Aladdin (AGA)_Disk2.adf"
089849f727eda32be724e0a5ff6e5714f5b46951  "Aladdin (AGA)_Disk3.adf"

Movie file and xml bundle

CasualPokePlayer commented 1 month ago

https://github.com/TASEmulators/BizHawk/blob/9825ac6db623aa927662662ef2a639eb0e70c069/src/BizHawk.Emulation.Cores/Computers/Amiga/PUAE.cs#L28-L29 Likely fault of these variables not included in savestates.

I assume the ""play back the movie"" step is leaving out you loaded a savestate from the beginning (maybe from the implicit TAStudio savestate on frame 0)

CasualPokePlayer commented 1 month ago

Check if 54fd290107d7b2a79d8033f0f289dd8d1bd190f3 fixes this

SergioMartin86 commented 1 month ago

Check if 54fd290 fixes this

This seems to work properly now for me