[Core: QuickerNES] Update and adding Arkanoid input support

TASEmulators / BizHawk

BizHawk is a multi-system emulator written in C#. BizHawk provides nice features for casual gamers such as full screen, and joypad support in addition to full rerecording and debugging tools for all system cores.

http://tasvideos.org/BizHawk.html

Other

2.21k stars 385 forks source link

[Core: QuickerNES] Update and adding Arkanoid input support #3997

Closed SergioMartin86 closed 2 months ago

SergioMartin86 commented 3 months ago

This PR updates QuickerNES to its latest commit which includes:

Its submodule 'jaffarCommon' now more compatible with compilation under Windows
ArkanoidNES and ArkanoidFamicom supported now

Check if completed:

[x] I have run any relevant test suites
[x] I, the committer, have read the licensing terms for contributors (last updated 2024-06-22) and am compliant

SergioMartin86 commented 3 months ago

Blocking because of the use of magic numbers. The rest are nitpicks.

I believe I addressed all your points, please re-review. Manually tested all input configuration and they still work

YoshiRulz commented 2 months ago

This doesn't include Virtual Pads for the new peripherals, but otherwise seems functional, so I've just added that to the to-do list in #3848.