Fix movie header values being potentially outdated upon starting a movie record

TASEmulators / BizHawk

BizHawk is a multi-system emulator written in C#. BizHawk provides nice features for casual gamers such as full screen, and joypad support in addition to full rerecording and debugging tools for all system cores.

http://tasvideos.org/BizHawk.html

Other

2.21k stars 385 forks source link

Fix movie header values being potentially outdated upon starting a movie record #4010

Closed Morilli closed 2 months ago

Morilli commented 3 months ago

closes #3980

Main behavior change here is to set minimal required header values into the movie when queueing it up, and setting all default values after the core has successfully rebooted. This ensures that all set values are accurate even if sync settings change on reboot.

YoshiRulz commented 2 months ago

I'm late, but diffs LGTM. Though it would have been nice to have this as at least 2 commits on the trunk.