TASEmulators / BizHawk

BizHawk is a multi-system emulator written in C#. BizHawk provides nice features for casual gamers such as full screen, and joypad support in addition to full rerecording and debugging tools for all system cores.
http://tasvideos.org/BizHawk.html
Other
2.21k stars 385 forks source link

Update/add more default input mappings #4012

Open TakuikaNinja opened 3 months ago

TakuikaNinja commented 3 months ago

This suggestion comes from the discussion in #3842.

The default controller mappings in general aren't updated often, so that might be doable here.

An especially glaring issue is that cores for computer systems (C64, ZX Spectrum, MSX, etc) lack default mappings for their keyboards. It would be a good idea to create sensible defaults for these, along with updating the rest of the mappings.

Asnivor commented 3 months ago

I was sure I included default mappings for ZXS. Looks like they were all removed to fix this (or another) issue: https://github.com/TASEmulators/BizHawk/commit/ec3a23259cf0f9528aef661b9df51846997485f4

If the key priority thing is now properly fixed, someone should be able to add the defaults back in maybe?

YoshiRulz commented 3 months ago

Ah, I was looking for https://github.com/TASEmulators/BizHawk/issues/3257#issuecomment-1786291002. To summarise my opinions:

vadosnaprimer commented 3 months ago

Similarly, I think mapping most of the host keyboard to the virtual keyboard is a bad out-of-the-box experience. If only because the default keybinds must not have conflicts.

We have a priority button exactly for those conflicts. If the goal is not ever having to use that button, then the replacement system should have been implemented first, before removing all keyboard bindings.

As I said there, having to rebind every key for every release is a worse experience.

Morilli commented 3 months ago

I wasn't aware of #3257 or ec3a23259cf0f9528aef661b9df51846997485f4 and now that I do I really don't understand the resolution.

How is a normal user expected to interact with virtual keyboard controllers, if not by mapping each of the virtual keys to a real key? Removing all default keybindings because some of them conflict with default hotkey keybindings is nonsensical imo. Why not remove all default hotkey bindings instead at that point?

We have a priority button exactly for those conflicts.

This. This problem of conflicts between hotkey and key bindings is already resolved in bizhawk through the priority system, and if this setting is somehow not adequate or not communicated clearly enough then that should be fixed, and not default bindings removed.