TASEmulators / BizHawk

BizHawk is a multi-system emulator written in C#. BizHawk provides nice features for casual gamers such as full screen, and joypad support in addition to full rerecording and debugging tools for all system cores.
http://tasvideos.org/BizHawk.html
Other
2.14k stars 380 forks source link

SMS overscan propagates to SG1000, and can't be turned off from there #961

Closed vadosnaprimer closed 7 years ago

vadosnaprimer commented 7 years ago

When you load an SG1000 ROM, while having the Overscan on for SMS, you'll get the same overscan for SG1000, and the latter doesn't give you the Overscan option in the menu, so you can't turn it off, unless you load an SMS ROM and disable it.

I tried to make the core ignore overscan if IsSG1000, but it broke everything.

vadosnaprimer commented 7 years ago

Actually, since SG1000 appears to use exactly similar screen as SMS, its overscan is also the same, so we don't need to disable it. But probably it would be nice to have it in the SG1000 options anyway, even if it shares the option with SMS? I dunno.

alyosha-tas commented 7 years ago

@vadosnaprimer try now, I think it's fixed

vadosnaprimer commented 7 years ago

Yes, thank you.