search

TASEmulators / TASEncodingPackage

http://tasvideos.org/EncodingGuide/PublicationManual.html
MIT License
4 stars 3 forks source link

Add an additional check for an uneven width. #26

Closed despoa closed 1 month ago

despoa commented 1 month ago

Certain parts of the script do not play well with uneven dimensions. There was a check for an uneven height, but not an uneven width. This fixes it.

Both checks are also moved to after the resizing functions as SD and HD resizing usually result in even dimensions. If neither happens or if uneven dimensions still remain, the checks will account for that.

vadosnaprimer commented 1 month ago

Does

https://github.com/TASEmulators/TASEncodingPackage/blob/0a2b0b4c6bf1beb3963e1723d1628073ebbd6aa2/encode.avs#L157-L163

not help?

despoa commented 1 month ago

That doesn't work for some reason. I tested it myself, but you can test it yourself if you want.

vadosnaprimer commented 1 month ago

How did you get the example footage?

despoa commented 1 month ago

I encountered this problem while trying to encode a couple recent Flash TASes, all of which had uneven dimensions. Here's a small sample video.

https://cdn.discordapp.com/attachments/925049317570527232/1288716302701039646/sample.avi?ex=66fa2695&is=66f8d515&hm=537b5312ebe9a16b7bb5b2b0f01d96836ae93213087e689199028fa3095a27df&

despoa commented 1 month ago

https://github.com/TASEmulators/TASEncodingPackage/blob/0a2b0b4c6bf1beb3963e1723d1628073ebbd6aa2/encode.avs#L199-L201

The conditional operators here turns out to be the problem. Removing them solves it. Closing.