TASEmulators / fceux

FCEUX, a NES Emulator
http://fceux.com
GNU General Public License v2.0
1.21k stars 251 forks source link

Move help source files to where people can see them #274

Open vadosnaprimer opened 3 years ago

vadosnaprimer commented 3 years ago

Currently here: https://github.com/TASVideos/fceux/tree/master/vc/Help

Since it's hidden so well, everyone was editing HTML files directly instead, which resulted in all their edits being wiped away upon proper update, which consists of editing the HND files and generating output in CHM and HTML format, as the readme explains.

@bbbradsmith would you like to put some info about your contributions into 2.3.0 whatsnew section (in https://github.com/TASVideos/fceux/blob/master/vc/Help/fceux.hnd)? I resurrected the documentation edits, but I haven't documented everything you're actually coded, since there's a ton.

bbbradsmith commented 3 years ago

Hmm. I can see why I never realized about the HND being source for those. That's a format I've never heard of, and being a binary file type we can't search it, and we can't see what's changed if anyone edits it. Also, as far as I can tell free version 3 of HelpNDoc is no longer available, and it looks like any attempt to edit the HND with the newer version is going to do some sort of "upgrade" to it, so I'm very hesitant to try editing them myself in the current state. (Edit: I had some version problems. The latest does work.)

Even trying to review the existing HND seems like a problem in this form, because the HelpNDoc editor has no way to search the current page, as far as I can tell? (Edit: it's a button on the right side of the "write" ribbon tab.)

Here's a list of changes I contributed since 2.2.3 (July 2016):

Changes prior to 2.2.3:

bbbradsmith commented 3 years ago

It looks like my documentation edits are not in the HND, so I'll have to review all of that as well.

vadosnaprimer commented 3 years ago

There's a dedicated toolbox button for searching, Ctrl+F does nothing.

bbbradsmith commented 3 years ago

Ah thanks. I had looked but missed it. It's in the "Write" ribbon page, all the way on the right side, as "Find and Replace".

bbbradsmith commented 3 years ago

Missing documentation changes that I was involved with:

Do you want me to edit these back in? As I mentioned, I cannot find a way to edit the HND file without upgrading/migrating it to the latest version, unless the old version that was used is still available somewhere?

I can see other changes in these two places, so I'm not sure if I was the only person editing the HTML directly by mistake? I haven't taken the time to look at the rest of these:

Edit: Apologies, my files were mistakenly out of date. The HND does load correctly with the current version of the program without upgrade, and almost all of my document changes were already in there. Will fix the one left over (extended palette format).

bbbradsmith commented 3 years ago

Okay, after getting the HND editing working I reviewed it for everything I listed above. PR above for the missing stuff.

ClusterM commented 3 years ago

Too bad than HND is a binary format. Maybe we should find some alternative?

vadosnaprimer commented 3 years ago

I agree but someone needs to find an alternative that can generate both CHM and HTML while using text files as a source.