Support for latest lua (version 5.3.5)

TASEmulators / fceux

FCEUX, a NES Emulator

http://fceux.com

GNU General Public License v2.0

1.21k stars 249 forks source link

Support for latest lua (version 5.3.5) #70

Open kulbhushanchand opened 5 years ago

kulbhushanchand commented 5 years ago

Hi,

The current FCEUX build (ver - 2.2.3) is using lua version 5.1.

Can we have support for latest lua version 5.3.5 ?

I tried replacing the lua5.1.dlland lua51.dllin the install directory of FCEUX, with the available lua53.dll, but not working (it keep on asking for lua51.dll).

movsb commented 5 years ago

Hi, If I remember correctly, versions after 5.1 have many incompatibles with 5.1. For what reasons you want to support the latest version?

kulbhushanchand commented 5 years ago

Hi @movsb

I was following some tutorial and having problem with loadstatement, only to realize FCEUX has version 5.1 and I should use loadstring. Changes like this may cause confusion sometimes.
The changelog since version 5.1- changelog lua v5.3 and changelog lua v5.2 also shows many improvements.

However currently I have no specific issue with FXEUX and lua v5.1.

AgentEnder commented 4 years ago

If acceptable I might put some time into working on this. I'm not sure how much would need to be changed, and it will be a while before I have a ton of time to dump into it, but it would be good to keep this up to date.

vadosnaprimer commented 4 years ago

I don't have any objections to newer lua, and I can't imagine any good reasons to force it to stay old.

AgentEnder commented 4 years ago

One option if there are major breaking changes (I've not done a lot of investigation yet), might be to include both .dlls and let the script authors decide which version their script is ran with? Default to the old version for compatibility reasons

mossheim commented 3 years ago

i built fceux locally on macOS using the lua version provided by homebrew (5.3.5) and ran it for a few hours last night with no major issues. one thing i noticed is that using an un-set variable in print() or other expressions crashes the app, but i think this may be related to #216 .

just to be clear, i used the "official" release from the website with lua 5.1 to test #216 and #215