TASEmulators / freej2me-plus

A free J2ME emulator with libretro, awt and sdl2 frontends.
https://tasemulators.github.io/freej2me-plus/
Other
0 stars 0 forks source link

Suggestions for the resolution and keycodes list #9

Open TwoSpacesSG opened 20 hours ago

TwoSpacesSG commented 20 hours ago

There's some weirdness in the resolution and keycode selectors AND some missing stuff ever since the original freej2me. Here are my suggestions.

Weird stuff

Resolutions

Some resolutions that exist are missing, I'll list them alongside devices that used those that have actual games preserved for those. Alternatively you may want to implement a "swap width and height" feature (Nokia Series 60 and KEmnnmod support swapping those in mid-game for screen rotation).

Keycode layouts

Many more exist than Nokia, Siemens and "Motorola". I attempted to gather a list of all the common ones that are seen in preserved games. You may want to implement a "swap softkeys" feature in order to eliminate the need for key layouts that are just Nokia (for Sagem) and Motorola Triplets (for certain games) but with swapped softkeys.

AShiningRay commented 6 hours ago

These are nice, the resolution list definitely need some touching up (i even did a round on them previously since some really popular screens weren't available), but as for the "swap width and height"setting, isn't this already in place by enabling Screen Rotation? Certain games do generate a non-rotated landscape framebuffer, so in those cases, the screen res itself should be landscape, with that being the case on both FreeJ2ME and KEmulator, which also require a content restart to properly render stuff on the new size.

A quick button to simply swap those would be a neat addition, but i don't feel it is really necessary right now, especially with the compatibility list being in its infancy where the more info we gather, the better.

As for keycode layouts, true, we're not only missing some of them, but also the "Standard" layout isn't exactly Standard. AFAIK it's only there precisely because it mirrors both num keys and nav keys, probably as a means of simplifying inputs for Libretro and RPi targets, as i do recall hex and recompile talking about some controllers not having enough buttons/axes to map complete key layouts. I wouldn't swap it over for Nokia, although i'd gladly rename it to "Gamepad" or something that better explains what it is intended to do... perks of trying to run this on as many platforms as possible early on.

Once i have time, i'll start with the res list do-over, then the key layouts since both are quite important. Until then, you can also submit a PR for those if you feel like it, i wouldn't mind reviewing and helping it along at all, especially with how much stuff still needs fixing here.