search

TASEmulators / gens-rerecording

The Gens rerecording project, a Sega Genesis, 32x, Sega CD emulator. The primary purpose is to expand features related to creating Tool-Assisted movies.
http://tasvideos.org/EmulatorResources/Gens.html
20 stars 10 forks source link

Hook RAM broken #115

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
This is with Gens11svn.zip r341.

The problem is that hook_log.txt was moved to a subfolder (HookLog), but the 
program still tries to read from the exe directory, not the subfolder.

What steps will reproduce the problem?
1. Edit .\HookLog\hook_log.txt, setting up some addresses to capture reads or 
writes of
2. Enable Tools->Tracing->Hook RAM, do something in the game that would print 
out some reads
3. Disable Tools->Tracing->Hook RAM, so that it writes to .\hook.txt.
4. hook.txt will not have any successful read/write logs.
5. Move hook_log.txt into the folder with the .exe.
6. Run a hook again as in steps 2-3
7. Now hook.txt has output results in it

It's up to whoever made the change, moving hook_log.txt to a subdirectory, but 
I guess the correct behaviour is to either do everything in the subfolder, or 
get rid of the subfolder and do everything in the .exe's folder.  the subfolder 
is a good idea, though.  although maybe the hook and trace stuff should share 1 
folder instead of being split up, as you always use them together.

Original issue reported on code.google.com by mcapew...@gmail.com on 20 Mar 2015 at 3:30

GoogleCodeExporter commented 9 years ago 
Thank you, will work on it soon.

PS: woah, it's already accepted!

Original comment by feykomylce on 20 Mar 2015 at 1:53

GoogleCodeExporter commented 9 years ago 
I fixed the paths, but I found something that doesn't look right. Enabling 
hooking creates hook.txt that only contains "MEMORY ACCESS LOGGING STARTED 
MEMORY ACCESS LOGGING STOPPED", but enabling it along with trace puts all the 
RAM hooks in the trace file along with traced code. Is hook.txt really 
seriously intended to only contain those 2 meaningless lines, all the hook log 
going to trace file?

Original comment by feykomylce on 27 Mar 2015 at 3:43

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r352.

Original comment by feykomylce on 27 Mar 2015 at 3:49

GoogleCodeExporter commented 9 years ago 
Given the question asked in #2, can I ask which way you decided to fix the 
issue?  Did you redirect the hook output to just the hook file, or both the 
hook and trace file? Or something else?
Thanks

Original comment by mcapew...@gmail.com on 27 Mar 2015 at 4:41

GoogleCodeExporter commented 9 years ago 
I only fixed what you reported, the thing my subfolder addition broke. But I 
don't know if posting hook logs to trace is intended, however it's how it was 
in the release. Hence I didn't touch it, I visualize a separate commit handling 
these once we come up with the solution. But from looking at how it was coded, 
I don't even understand the logic.

Original comment by feykomylce on 27 Mar 2015 at 5:41