search

TASEmulators / gens-rerecording

The Gens rerecording project, a Sega Genesis, 32x, Sega CD emulator. The primary purpose is to expand features related to creating Tool-Assisted movies.
http://tasvideos.org/EmulatorResources/Gens.html
20 stars 10 forks source link

Fixed an old Gens bug with savestate colors #122

Closed lab313ru closed 7 years ago

lab313ru commented 8 years ago

Colors were swapped.

hegyak commented 8 years ago

What does this correct?

lab313ru commented 8 years ago

When you're using the GSavestate program, bytes of CRAM colors are swapped in it. This commit fixes that, so you'll see normal colors in savestates.

vadosnaprimer commented 8 years ago

Does it make old savestates incompatible/broken?

lab313ru commented 8 years ago

I think, all colors in old savestates will be swapped after that.

marzojr commented 8 years ago

This REALLY should not have commits 9962f49 and 86c1407; there is already a pull request for them. I am recommending to reject this unless these commits are removed.

vadosnaprimer commented 8 years ago

Yeah, otherwise it's probably alright to merge, since states remain working overall, and even that is from time to time broken by development, and people have to deal with it.

marzojr commented 7 years ago

I cherry-picked the savestate fix; so closed by 9b6c5420a34b079e5b8de35611e18a98490d2df2.