TASEmulators / pcem

PCem (short for PC Emulator) is an IBM PC emulator. This version of PCem has multi-threading disabled in order to ensure determinism when running though libTAS.
http://tasvideos.org/EmulatorResources/PCem.html
GNU General Public License v2.0
5 stars 1 forks source link

Config cdrom_path entry only reads up to 255 characters in that line #17

Open IAmTrial opened 3 months ago

IAmTrial commented 3 months ago

The config entry only reads the first 255 characters in that line. This includes the name of the entry cdrom_path and the = character, effectively leaving at most only 244 characters available to specify the list of paths. There is no warning for this, which has lead to confusion.

This is because the config reader is set up to only read up to 255 characters (plus null char) per line. In a scenario where longer file paths may be used, and multiple discs are needed for a particular install, there is not a lot of room to add more disks. I am proposing to increase the character limit per line (taking into account that the image_list character limit is 4095 plus null char), and/or to warn whenever a line is too long.

Current workaround is to use shorter paths to files and shorter filenames.

vadosnaprimer commented 3 months ago

Makes sense.