TASEmulators / pcem

PCem (short for PC Emulator) is an IBM PC emulator. This version of PCem has multi-threading disabled in order to ensure determinism when running though libTAS.
http://tasvideos.org/EmulatorResources/PCem.html
GNU General Public License v2.0
5 stars 1 forks source link

Remove capture/non-captured logic? #4

Closed clementgallet closed 3 years ago

clementgallet commented 3 years ago

PCem has captured and non-captured mode, so that users can escape the system and use right-click for menu. When running with libTAS, non-captured mode becomes useless, because we don't and can't use the right-click menu, and also because libTAS prevents the mouse grabbing.

So, should we disable non-captured mode? That would mean that users won't be able to use PCem much outside of libTAS though.

vadosnaprimer commented 3 years ago

I think as long as it doesn't introduce problems, we want to minimize the amount of differences we introduce compared to upstream. So it should be ok to leave this mode as available. Probably to allow free use of it outside libtas, which is sometimes easier.

vadosnaprimer commented 3 years ago

Closing until we find out we actually need this tweak.