Remove DolphinQt2 - Githubissues

TASLabz / dolphin-lua-core

do not use - obsolete

GNU General Public License v2.0

8 stars 2 forks source link

Remove DolphinQt2 #30

Closed malleoz closed 2 years ago

malleoz commented 2 years ago

Dolphin Lua Core is based on Wx. The version of Dolphin we are based off of was in the transition phase going towards Qt, but it is not fully implemented. Thus, Wx must still be used for this version, meaning all Qt dependencies/references should be removed.

To review this PR: Check that there are no remaining references to Qt anywhere in source code.

malleoz commented 2 years ago

Found a couple files that were also unnecessary, but unsure about the following:

\Tools\deploy-mac.py (is this even used? What is its purpose)

malleoz commented 2 years ago

This should be good now. The one uncertain file deploy-mac.py.... I've identified that it's still required for Mac building as it is directly referenced in the CMakeList.txt. So all I did was remove its references to Qt.

It's currently untested so I'd like to get a Mac user to build this before I merge.

malleoz commented 2 years ago

From hibyehello: "iirc that [file] packages up the binary for macs, but it isn't needed. cmake works just great for everything mac".

Thus, I'm okay with this being merged now.