search

TASLabz / dolphin

Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.
https://dolphin-emu.org/
Other
5 stars 3 forks source link

Upgrade Python Version to 3.12 #18

Open ximk opened 1 year ago

ximk commented 1 year ago

Currently, the Python version the scripting engine uses is 3.8.5. On 3.10, the most notable changes would be the addition of match case statements, along with supporting the use of | for type unions natively. Mac and Linux(?) versions use whatever Python version is installed on the user's computer, but on Windows, it forces the use of 3.8.5. With the deprecation of Py_SetPath in 3.11, I believe 3.10 is our best option at the moment.

Hibyehello commented 1 year ago

SetPath still works in 3.11 for compatibility reasons

Avasam commented 1 year ago

SetPath still works in 3.11 for compatibility reasons

☝️ If it's just deprecated, it should still be usable (just means you need to start looking for an alternative). Of interest for this project imo: 3.11 is much faster and has integrated support for parsing TOML files. (and a couple other cool things that don't matter as much here: https://www.python.org/downloads/release/python-3110/)

ximk commented 1 year ago

Changed title to reflect the feedback from others.

ximk commented 1 year ago

Also, we may want to consider (if possible) forcing Mac/Linux OSes to use the embedded python version to ensure that all scripts are compatible with each OS given the same build of Dolphin.

ximk commented 1 year ago

Updated title to reflect the newest Python release.

malleoz commented 1 year ago

What impact will PEP 684 have? https://youtu.be/8l4UWz48Elc?si=YJCZLXlNhzE8EhJ6&t=149