search

TASRobotics / RaidZero-FRC-2019

Competition code for 2019 season
1 stars 0 forks source link

Hermite spline #24

Closed qsctr closed 5 years ago

qsctr commented 5 years ago

Use hermite spline for path generation, so we can configure the starting and ending angles.

Gediminas19 commented 5 years ago

I think I committed it with Hermite Spline to the onboard-pathing branch. Help me check if it violates the style guide.

I also am not 100% sure it works because I didn't copy everything exactly from my testing code that works, but it should.

qsctr commented 5 years ago

Okay, but I told you to wait until #23 was merged...

I'll make a few changes to your code, then @Kof223 can review it again. I don't think @bayntun will have time to review it.

qsctr commented 5 years ago

Actually, I think I will revert your commit and merge #23. Then you can create a new branch and pull request for hermite, and I will copy your old commit onto that branch. But you have to be the one that creates the PR so I can review it.

Gediminas19 commented 5 years ago

My hemite-sp commit seems to compile, as in when I used Gradle it passed the compileJava step and only broke after not finding the robot.

Gediminas19 commented 5 years ago

Scratch that, there are actually other issues.

EDIT: I fixed it so the linter has no complaints anymore. I will be testing it for real later today.

qsctr commented 5 years ago

FYI you can use the Build Robot Code option in the wpilib extension or run gradlew build to build the code without deploying.