Closed Gediminas19 closed 5 years ago
Did the changes go through?
Yes, but don't merge yet
Wait, there's another line that needs spaces.
Help, is there a way for me to switch branches so I can make edits without losing my work in the branch I'm working on right now (Vision)?
Try online editing
Was it only the other cumPos line? Or do you see more?
I believe that's it. Why are we waiting?
@qsctr Are there other changes that should be made?
yes, hold on
lol "hold on" reminds me of matlab
In addition to the stuff above, I'm trying to make sure the spline polynomial calculation + the new methods for calculating angle and position have no significant impact on performance
What do you mean no significant impact?
As in, it doesn't make it much slower than before
Benchmark testing?
I haven't set up any benchmarks (yet?), just very unscientific testing
Okay, performance should be fine (i think?)
Also FYI you don't need to dismiss reviews manually, except if you can otherwise merge.
Ok, can't believe I did 2 separate commits for that. Anyways, are there nice extensions or just settings that enable you to either notice or eliminate trailing whitespace?
files.trimTrailingWhitespace
Someone check this request for Hermite Spline.
It works on the robot, so it should be fine.
Closes #24.