TASRobotics / RaidZero-FRC-2019

Competition code for 2019 season
1 stars 0 forks source link

Hermite spline #30

Closed Gediminas19 closed 5 years ago

Gediminas19 commented 5 years ago

Someone check this request for Hermite Spline.

It works on the robot, so it should be fine.

Closes #24.

Gediminas19 commented 5 years ago

Did the changes go through?

qsctr commented 5 years ago

Yes, but don't merge yet

Kof223 commented 5 years ago

Wait, there's another line that needs spaces.

Gediminas19 commented 5 years ago

Help, is there a way for me to switch branches so I can make edits without losing my work in the branch I'm working on right now (Vision)?

Kof223 commented 5 years ago

Try online editing

Gediminas19 commented 5 years ago

Was it only the other cumPos line? Or do you see more?

Kof223 commented 5 years ago

I believe that's it. Why are we waiting?

Gediminas19 commented 5 years ago

@qsctr Are there other changes that should be made?

qsctr commented 5 years ago

yes, hold on

qsctr commented 5 years ago

lol "hold on" reminds me of matlab

qsctr commented 5 years ago

In addition to the stuff above, I'm trying to make sure the spline polynomial calculation + the new methods for calculating angle and position have no significant impact on performance

Gediminas19 commented 5 years ago

What do you mean no significant impact?

qsctr commented 5 years ago

As in, it doesn't make it much slower than before

Gediminas19 commented 5 years ago

Benchmark testing?

qsctr commented 5 years ago

I haven't set up any benchmarks (yet?), just very unscientific testing

qsctr commented 5 years ago

Okay, performance should be fine (i think?)

qsctr commented 5 years ago

Also FYI you don't need to dismiss reviews manually, except if you can otherwise merge.

Gediminas19 commented 5 years ago

Ok, can't believe I did 2 separate commits for that. Anyways, are there nice extensions or just settings that enable you to either notice or eliminate trailing whitespace?

qsctr commented 5 years ago

files.trimTrailingWhitespace