TASRobotics / RaidZero-FRC-2019

Competition code for 2019 season
1 stars 0 forks source link

Vision #83

Closed Kof223 closed 5 years ago

Kof223 commented 5 years ago

The 8 point works, but shin yi will work on the 6 point.

qsctr commented 5 years ago

I'm sort of confused why this branch is being merged right now. From what I'm seeing it just has the vision code but it doesn't seem to be used in teleop or anything. Auto class still contains vision testing code and not driver control for sandstorm. You might also want to revert limelight settings if we aren't actively using vision processing. Code in master branch should be finished, competition-ready code, not development code. I don't think we are using vision in competition right now so non-vision code should be left alone.

If this merge is just to get the working vision code into master but not actually use it on the robot, then the only things that should be added are stuff in the vision package and the rest of the robot code should be left the same without testing code or random stuff. Alternatively, we can integrate the vision code into teleop controls and/or autonomous and then merge that once it is competition-ready. I don't really see the need to merge right now though.

Kof223 commented 5 years ago

Then how do I merge just the vision package?

Kof223 commented 5 years ago

Actually, I think I will branch off from this branch, update from master and remove all the testing code. Then I will add a teleop button for tracking.

qsctr commented 5 years ago

Ok, closing this PR then.