search

TASVideos / tasvideos

The code for the live TASVideos website
https://tasvideos.org/
GNU General Public License v3.0
63 stars 28 forks source link

Detect and display firmware used in Submission page #1554

Open Spikestuff opened 1 year ago

Spikestuff commented 1 year ago

Similar to #1033 but with a different goal in mind.

Especially for PlayStation to provide the information from the Firmware used and state which region the bios is in. A current submission has a major issue because of this. Not only is it not using the expected bios (scph5500) but it's also using an NTSC-U bios (scph1001) for an NTSC-J game.

Obviously writing that if it used an NTSC-J bios such as scph1000 it would've been fine, but the mismatch is major to actually know what the author(s) are using.

adelikat commented 1 year ago

My hesitation about this and the similar issue, is that these are so bizhawk specific. I know it is the most submitted emulator, but I would want to be careful about catering everything to it

Spikestuff commented 1 year ago

Understood. It's just that this issue is a common one where the Judges do have sync issues sometimes, and instead of having them do either guesswork and/or looking into the Header and going "Ah, it's that bios" it would be simpler to just have a thing that outright states it.

But this is also mainly a PlayStation issue^ which is only BizHawk... would being able to detect the PSX Platform be more of a reasonable choice (or doable) in actually showing this extra bit of vital information as an extra part of that table?

Trash concept: image Demo explanation: It's marked with the exclamation mark as the Game Version (JPN) doesn't match the Bios Version (USA).

^There is a case to argue with the Game Boy submissions that use an AGB bios to also have this specific information, but personally I believe that informing the string of text to a bios to something we're usually accustomed to is more important.

nattthebear commented 1 year ago

these are so bizhawk specific

Only because other emulators haven't implemented storing the information in movies. It's still relevant information for some other platforms as well.

CasualPokePlayer commented 8 months ago

The site would need to be storing hashes of many different firmware files and mapping them out to friendly names for this to work nicely (i.e. any better than what's built into BizHawk), effectively mirroring the giant firmware DB BizHawk has (for sanity you'd need to have some catalogging system here). For BizHawk, any firmware hash in the header would also have different keys depending on what kind of firmware is used (the format being <firmware console id>_Firmware_<firmware id>), and firmware ids are not particularly consistent (for the idea of detecting a mismatched firmware region: so know if the firmware entry is supposed to be some Japanese firmware entry, you'd need to figure that out from possibilities like NAND_JPN, bios_basic_jpn, J, CD_BIOS_JP, Japan, IPL_JPN, and probably more in the future) which would be slightly annoying to parse and may require more additions to the parser as time goes on.

Which really, judges shouldn't have much issue in this area in the first place, the firmware hash is in the header, and the header is shown in the Play Movie dialog, and it will even be highlighted yellow if the bound firmware does not match. The firmware config can additionally show all the hashes known for any particular firmware entry.