TASVideos / tasvideos

The code for the live TASVideos website
https://tasvideos.org/
GNU General Public License v3.0
62 stars 29 forks source link

External links should open in a separate tab #1679

Closed Masterjun3 closed 1 year ago

Masterjun3 commented 1 year ago

In general, sites on the web are made to open in a new tab if they lead to a different domain. We currently open these links in the same tab. We should make them open in a different tab.

We also currently use this specific icon. It is the icon to tell users it will open in a different tab. image (Meaning even if we don't want to open in a different tab for some reason, at least that icon then needs to change.)

RetroEdit commented 1 year ago

I'd personally prefer to have a choice on where links open. In most web browsers, it's easy enough to open links in a new tab by using Ctrl+click, middle click, or right-clicking and then selecting Open Link in New Tab.

That icon does not universally signify links will open in a new tab. Wikipedia uses a similar icon, and the links do not open in a new tab by default.

moozooh commented 1 year ago

I think this should depend on the user agent. For PC browsers, this is completely a non-issue because middle-click and ctrl-click exist, so, at least in theory, there should never be a situation when a user would prefer forfeiting the option to choose whether they want to stay on the current tab when opening a link.

Mobile devices are a different story, however, as their simplified, stripped-down interface encourages a different UX. So I could very well see it being appropriate and even welcome in that case. But not on PC.

Masterjun3 commented 1 year ago

It seems the suggestion by me is unwanted, so I'm closing my issue.

YoshiRulz commented 1 year ago

If you're on mobile Android and a link opens in the current tab, it's super easy to hit Back, long-press, "Open in new tab". Arguably easier than doing the same with a mouse on desktop.