search

TASVideos / tasvideos

The code for the live TASVideos website
https://tasvideos.org/
GNU General Public License v3.0
62 stars 29 forks source link

[F.Rq.] Enumerate submissions on game pages #1686

Open YoshiRulz opened 1 year ago

YoshiRulz commented 1 year ago

I assume this was only done for pubs since subs could far outnumber pubs, but in practice there's often only a few. A simple flat list would save a click / page load.

vadosnaprimer commented 1 year ago

the list can be giant for some games.

adelikat commented 1 year ago

the list can be giant for some games.

https://tasvideos.org/1G

Masterjun3 commented 1 year ago

I assume this was only done for pubs since subs could far outnumber pubs

For reference, this was actually only done for pubs because every additional information we have to show, is additional load for the db for that single page load. So the reasoning that it "saves" a page load does not apply in general. Users not clicking the submission list far outnumber those who do.

YoshiRulz commented 1 year ago

the list can be giant for some games.

Yes, it would need to be conditional: use a list if the number of subs (looks to be exposed as Model.Game.SubmissionCount) is under a threshold, else use the current code.

vadosnaprimer commented 8 months ago

What's the scenario where seeing submissions right away is critical/important?

YoshiRulz commented 8 months ago

Say you knew someone made a submission for game X and you wanted to view it. Going via subs: You can't currently filter subs by game (edit: from that GUI; as feos pointed out to me, the subs link on game pages in fact takes you there with the relevant queryparam populated), but you can filter by system, which should be enough assuming the queue stays under control. Going via games: (this issue). This would just be a small quality-of-life improvement to "game-first" browsing.

vadosnaprimer commented 8 months ago

This is why I asked how important it is in real life. How often do you have to do the extra click to actually go and see the submission list for a given game? I would say it's rare enough to remain hidden behind a link at all times (no threshold), because overwhelming majority of users only watch publicatons. And even if you don't want to watch the publications, simply checking current branch list for maintenance is more frequent than checking submissions for anything.