User-facing error messages could be more precise

TASVideos / tasvideos

The code for the live TASVideos website

https://tasvideos.org/

GNU General Public License v3.0

62 stars 29 forks source link

User-facing error messages could be more precise #1693

Open YoshiRulz opened 12 months ago

YoshiRulz commented 12 months ago

[ ] /Users/Profile/<u> with nonexistent user is generic 404, but could say "no such user"
[ ] /<n>{G,M,S} with nonexistent ID is generic 404, but could say "no such {game,pub,sub}"
- -1G doesn't have a game page but does exist, kinda
others?

see also #1580 re: auth redirecting back to error which no longer applies after auth

RubenVercaemst commented 11 months ago

Hi, I would like to work on this issue if possible :)

adelikat commented 11 months ago

Well, it isn't claimed, so go for it. But I'm not sure what exactly the plan is, the page is generic, it would need to know what kind of page it is, to show a different message

RubenVercaemst commented 11 months ago

I took a look, the project is using ExceptionHandler and StatusCodePagesWithReExecute middleware. The original request path can be retrieved through that middleware, depending on that path we could pass specified ExceptionMessages.