TASVideos / tasvideos

The code for the live TASVideos website
https://tasvideos.org/
GNU General Public License v3.0
62 stars 29 forks source link

Remove unused HTML IDs appearing on every page #1722

Closed Masterjun3 closed 7 months ago

Masterjun3 commented 7 months ago

This basically reverts #612 and #613 which where merged but never used for tests afterwards.

This fixes the issue where our TOC could not navigate to headers that collided with these IDs, e.g. https://tasvideos.org/ReverseEngineering#Emulators

In general, we should use HTML IDs very sparingly, because of exactly this feature we want to support. (If we ever want Selenium tests like the two PRs were a preparation for, we should consider just using html classes, which can then be selected.)