Masterjun3
commented
1 month ago Actually, my initial change short-circuits the function, so Pubs and Subs aren't updated. And it seems this code block isn't needed anyway. So let me add a commit.
Closed Masterjun3 closed 1 month ago
Masterjun3
commented
1 month ago Actually, my initial change short-circuits the function, so Pubs and Subs aren't updated. And it seems this code block isn't needed anyway. So let me add a commit.
Resolves #1868 .
@adelikat ~~I assume my edit is what that particular code block was meant to do in the first place. If my assumption is wrong you should definitely look at this. (Because we use case-insensitive columns, right? Requiring us to preempt the DB and manually allow changes if the only difference is their case.)~~ I removed that whole if-block, but I wasn't quite sure what its purpose was. I assumed it had something to do with our DB using case-insensitive columns, but this shouldn't matter here.