Closed Masterjun3 closed 4 days ago
Good review @nattthebear . It makes sense. If I use optimization as a reason to not follow convention, then I should properly optimize everywhere. I will resolve this in a few hours, when I have more time.
Those commits should do it.
Relevant to #1644 .
Basically, our meta tag descriptions on wiki pages currently show when the page was last edited. Which isn't really useful. What would be useful instead is to take the first few lines of the wiki and put the text of that into the description!
So this was the idea (before | after):![image](https://github.com/TASVideos/tasvideos/assets/22375320/86190ad0-564c-4087-95e0-a08c6162b7c1)
Now, our wiki system is quite complicated. And we don't know if we want to add even more complexity to it. I basically tried to minimize the changes, and I made 3 commits that build upon each other, but are self-contained and can be run on their own.
Problem: The Youtube renderer renders links. But that isn't really useful for meta tag descriptions. This is somewhat solved by the 2nd commit.
Problem: All the big things like TOCs and Tabs are rendered at the start, which makes the meta tag description useless again.
Finally it looks good to me.
However
However, this is quite the complexity added. If this is too much or we want to implement it differently, maybe after a rewrite or refactor of wiki stuff, then this PR can be closed. I just wanted to try how much it really is, because I do enjoy the results:
More examples:
![image](https://github.com/TASVideos/tasvideos/assets/22375320/c8e7b73e-817f-4b3c-a2eb-9db4bf802d91)