search

TASVideos / tasvideos

The code for the live TASVideos website
https://tasvideos.org/
GNU General Public License v3.0
62 stars 29 forks source link

Automate the per-platform movie table #1910

Closed vadosnaprimer closed 6 days ago

vadosnaprimer commented 3 months ago

https://tasvideos.org/Movies

First tab. We have to add the links manually every time a new platform appears.

Per-class links are not always there, but I think it makes sense to show them as long as they're not empty.

Stars are a flag now, but I'm not sure if it's worth removing it from that table yet. They work as a good way to promote cooler movies right away.

adelikat commented 2 months ago

For anyone looking to pick this up, we simply need a wiki module

YoshiRulz commented 2 months ago

Per-class links are not always there, but I think it makes sense to show them as long as they're not empty.

Are you suggesting the module should include those unconditionally, or that it should do extra checks?

YoshiRulz commented 2 months ago

Well that only took a few minutes, but besides the above issue, it also differs from the manual table in that it doesn't group any platforms together (list taken from IGameSystemService).

vadosnaprimer commented 2 months ago

Are you suggesting the module should include those unconditionally, or that it should do extra checks?

If the sub-list is not empty, link to it.

YoshiRulz commented 3 days ago

This was implemented and is ready to be used on /Movies: after Compare to the existing, manual table: before

Checking for empty categories and omitting those links was not implemented.

As I posted under the PR, the existing groupings become:

[module:PublicationsByPlatform|groupings=A2600-A7800,Jaguar-JaguarCD,GB-SGB-GBC,DOS-DOOM-Windows-Linux,MSX-SVI3x8,NES-FDS,N64-N64DD,DS-DSi,Genesis-32X-SegaCD,SMS-GG-SG1000,SNES-BSX,PCE-PCECD-SGX]