search

TAXIIProject / django-taxii-services

Installable taxii_services
http://taxiiproject.github.io/
BSD 3-Clause "New" or "Revised" License
20 stars 13 forks source link

Disabled Inbox Services being shown for CollectionInformationRequest #28

Closed SyntaxGeek closed 9 years ago

SyntaxGeek commented 9 years ago

Running a scripted CollectionInformationRequest against a collection management service for a given data collection is returning inbox services that have been disabled (Enabled=False).

I believe this is because the data collection used in the CollectionInformationRequest is still set as a destination data collection in the inbox service configuration.

When I remove the data collection from the destination collection list in the inbox service configuration and re-run the CollectionInformationRequest script the inbox service is no longer shown.

So it seems like when the CollectionInformationRequest message is received and the CollectionInformationResponse is being formed there needs to be an added check during the inbox services inclusion loop to make sure the inbox service is enabled.

Let me know if you need anymore info.

MarkDavidson commented 9 years ago

@SyntaxGeek, thanks for reporting. This problem actually occurs in more places than just for the inbox service. I'll work on a fix (which will mostly be just setting enabled=True on all the queries).

Thank you. -Mark