search

TAXIIProject / django-taxii-services

Installable taxii_services
http://taxiiproject.github.io/
BSD 3-Clause "New" or "Revised" License
20 stars 13 forks source link

PollService does not enforce requires_subscription #38

Open MarkDavidson opened 9 years ago

MarkDavidson commented 9 years ago

Per @I-am-Sherlocked [1]:

I'm not sure if this is the right place to ask, but why isn't PollService's "requires_subscription" field not enforced anywhere? When setting the field to true, shouldn't the poll service verify consumer's subscription?

-Mark [1] https://github.com/TAXIIProject/libtaxii/issues/164

MarkDavidson commented 9 years ago

My response from the other thread:

[T]he short answer is that it just hasn't been implemented it. You are 100% correct with the expected behavior. Partly, the subscription workflows are not well tested and therefore immature, and any code-level tie-in from the Poll Service to a Subscription's state might change as the Subscription concept matures.

One note (and I try to repeat this often) is that asking for these features will help increase their priority/visibility to the TAXII team, so please keep bringing them up! We also gladly accept code contributions.