search

TAXIIProject / yeti

YETI is a TAXII implementation
BSD 3-Clause "New" or "Revised" License
46 stars 19 forks source link

Remove outdated static/admin in favor of newer files bundled with Django #71

Closed guidovranken closed 9 years ago

guidovranken commented 9 years ago

I noticed that the https://github.com/TAXIIProject/yeti/tree/master/yeti/static/admin/js directory contains files, such as jquery, which are nearly 5 years old. If you remove this directory, Django will automatically use the more recent files bundled with its installation on the system, residing in django/contrib/admin/static/admin/.

I don't know if the current set of outdated files in the current setup could be vulnerable to XSS or a similar JS-based attack. but at any rate I'd opt to use the recent files bundled with Django (for reasons given by @MarkDavidson in https://github.com/TAXIIProject/yeti/issues/70).

Guido

MarkDavidson commented 9 years ago

A while back (In YETI 1.x), something (I forget what) wasn't working and copy/pasting all the static stuff from the Django admin directory got it to work. That seems to no longer be necessary.

I deleted all the static/admin items, and YETI still seems to work just fine for me. If somebody else can run YETI and confirm it looks right, this pull request can be merged.

-Mark