TB-throwback / LookOut-fix-version

Fork of LookOut (fix version)
51 stars 17 forks source link

Lookout not triggered when setting "Open message in" set to "A new message window" #50

Closed steosch closed 3 years ago

steosch commented 4 years ago

Expected Behavior

Mails received from MS Outlook should be decoded to allow accessing attachments

Current Behavior

Attachments are not decoded; mail attachment just shows winmail.dat only. Attachments can be accessed though by saving the respective e-mail and using Outlook.

What is the current behavior?

Installing the plugin seems to have not effect; I also tried to remove the plugin, close TB's plugin panel and restart TB. Reinstalling the plugin unfortunately did not mitigate the issue.

Steps to Reproduce

Install plugin and open an Outlook message --> winmail.dat shows up. Attachments are not decoded. Message window w/ plugin installed is identical to TB w/o plugin.

Failure Information (for bugs)

Activated debugging and filtered for entries with "lookout"; here are the results: LookOut: debug enabled LookOut: Entering LookoutLoad() LookOut: Entering startup() LookOut: registering messageHeaderSink.onEndAllAttachments hook stylesheets actor: fetch failed for chrome://lookout/skin/overlay.css, using system principal instead. stylesheets.js:246:13 fetchStylesheet resource://devtools/server/actors/stylesheets.js:246

Unfortunately that seems to be all that I can provide for debugging purposes.

Cheers and keep up the good work, Stefan

dugite-code commented 4 years ago

You should see at least LookOut: Entering scan_for_tnef() in the log.

Do you have Control folder access enabled in Windows (Found under Ransomware protection). I've had issues with that in the past

steosch commented 4 years ago

FYI: I have updated to TB 6.3 64 bit just to be sure -- issue still persists.

LookOut: Entering scan_for_tnef()

When searching for "lookout" I get the following lines:

WebExtensions: Loading packed extension from C:\Users\steosch\AppData\Roaming\Thunderbird\Profiles\1234567.default-release\extensions\lookout@s3_fix_version.xpi
WebExtensions: Loading add-on preferences from  C:\Users\steosch\AppData\Roaming\Thunderbird\Profiles\1234567.default-release\extensions\lookout@s3_fix_version.xpi
WebExtensions: Firing profile-after-change listeners for lookout@s3_fix_version
LookOut: debug enabled 
LookOut: Entering LookoutLoad()
LookOut: Entering startup()
LookOut:    registering messageHeaderSink.onEndAllAttachments hook
stylesheets actor: fetch failed for chrome://lookout/skin/overlay.css, using system principal instead.  stylesheets.js:246:13
fetchStylesheet resource://devtools/server/actors/stylesheets.js:246

Nothing to be found when using "scan_for_tnef" as search phrase -- that's all I'm afraid.

What options in the lookout preferences do you have enabled?

Options enabled (I use the German version): [ ] MAPI Eigenschaften speichern [ ] Kalenderdaten direkt öffnen [ ] Konverson der Karaktertabelle für Dateiname verbieten [ X ] Entfernen Sie winmail.dat [ X ] Strict Content-Typ-Übereinstimmung [ X ] Aktivieren Sie das Debuggen <-- temporarily active to provide further inputs

Have you tried disabling strict Content Type Matching option?

Yes (+ TB restart after unchecking the respective option) -- sadly, the issue still persists.

Please let me know if I can be of any further help. Cheers

steosch commented 4 years ago

Do you have Control folder access enabled in Windows (Found under Ransomware protection). I've had issues with that in the past

Seems to be related to Windows Defender -- I'm using Kaspersky. TB and all other plugins work without glitches, so I suppose the respective settings are OK.

GSNord commented 4 years ago

I have the very same problem on TB 68.2.0 At the start of TB I receive the following messages:

WebExtensions: Loading packed extension from C:\Email\Profiles\extensions\lookout@s3_fix_version.xpi ext-legacy.js:157
WebExtensions: Loading add-on preferences from  C:\Email\Profiles\extensions\lookout@s3_fix_version.xpi ext-legacy.js:190
WebExtensions: Firing profile-after-change listeners for lookout@s3_fix_version ext-legacy.js:194
LookOut: debug enabled 
LookOut: Entering LookoutLoad()
LookOut: Entering startup()
LookOut:    registering messageHeaderSink.onEndAllAttachments hook

When I open an email containing winmail.dat, there is absolutely no activity in the log. I have Windows Defender running, no other antivirus tool. The "Control folder access" is not enabled.

dugite-code commented 4 years ago

Do either of you have other extensions installed? I have 9 Machines on windows 10 and am currently unable to find a way to reproduce the issue

GSNord commented 4 years ago

Hello dugite-code, I am on Windows 10 Pro 1909. My other extensions are

steosch commented 4 years ago

I have

installed, both are active.

PS: The top comment let under [1] seems to confirm the issue as well

[1] https://addons.thunderbird.net/en-US/thunderbird/addon/lookout-fix-version/

dugite-code commented 4 years ago

Unfortunately untill I can figure out how to replicate this issue I can't fix it.

I have a couple of ideas to try

GSNord commented 4 years ago

Any additional information we can provide? Some hidden logfiles in the profile or user folders?

dugite-code commented 4 years ago

Can you try the v2.0.01b1 release. It's a bit of a swing in the dark if I'm honest but might fix the issue

GSNord commented 4 years ago

Sorry, but still no change. After startup of TB, I have these messages in my log:

Log ```js _WebExtensions: Loading packed extension from C:\Email\Profiles\extensions\lookout@s3_fix_version.xpi ext-legacy.js:157 Ignoring unrecognized chrome manifest directive 'overlay'. chrome.manifest:17 Ignoring unrecognized chrome manifest directive 'overlay'. chrome.manifest:19 Ignoring unrecognized chrome manifest directive 'overlay'. chrome.manifest:1 Ignoring unrecognized chrome manifest directive 'style'. chrome.manifest:3 Ignoring unrecognized chrome manifest directive 'overlay'. chrome.manifest:5 WebExtensions: Loading packed extension from C:\Email\Profiles\extensions\{8845E3B3-E8FB-40E2-95E9-EC40294818C4}.xpi ext-legacy.js:157 WebExtensions: Loading add-on preferences from C:\Email\Profiles\extensions\lookout@s3_fix_version.xpi ext-legacy.js:190 WebExtensions: Firing profile-after-change listeners for lookout@s3_fix_version ext-legacy.js:194 WebExtensions: Loading add-on preferences from C:\Email\Profiles\extensions\{8845E3B3-E8FB-40E2-95E9-EC40294818C4}.xpi ext-legacy.js:190 WebExtensions: Firing profile-after-change listeners for {8845E3B3-E8FB-40E2-95E9-EC40294818C4} ext-legacy.js:194 [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIFile.initWithPath]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://quicktext/content/modules/wzQuicktext.jsm :: loadSettings :: line 249" data: no] wzQuicktext.jsm:249:18 LookOut: debug enabled LookOut: Entering LookoutLoad() LookOut: Entering startup() LookOut: registering messageHeaderSink.onEndAllAttachments hook_ ```

No more activity when opening a mail containing winmail.dat

steosch commented 4 years ago

Sry for my late reply -- same on my side, issue still persists after installing v2.0.01b1 release...

erik2282 commented 4 years ago

This is also happening to me on tbird 68.2.2 but on Debian Linux. I'll try updating to tbird 68.3 tonight after users log off.

erik2282 commented 4 years ago

I updated to the newest version of thunderbird available in the Debian Jessie repo, and it still happens. I've had to put users on older versions of thunderbird to get the functionality back.

dugite-code commented 4 years ago

@erik2282 is any of the 68.x versions working or have you down graded back further

justmelly commented 4 years ago

@dugite-code, @erik2282 and I work together and are trying to fix this issue. We have tried different versions of 68.x and still the same issue. I am fixing to throw you a curve ball here though. We have a test system with Debian 8 installed. Thunderbird is version 68.4 and the Lookout plugin is version 2.0.0. We have two different users set up. One of the users plugin works to see the contents of the winmail.dat and the other does not. I made sure the prefs.js file matches and it does. I am still inspecting what else is different between the users without much luck. Makes no sense because it's the same Thunderbird application they are using. The only difference is the user itself.

justmelly commented 4 years ago

@dugite-code I can show you a debug from a working user vs a non working user. It looks like it's not able to write to the tmp directory due to a permission issue. Where is the tmp directory located?

WORKING ```js LookOut: debug enabled LookOut: Entering on_end_all_attachments() LookOut: Entering scan_for_tnef() ({message:({}), contentType:"application/ms-tnef", name:"winmail.dat", url:"imap://USER/fetch%3EUID%3E/INBOX%3E359561?part=1.2&filename=winmail.dat", uri:"imap-message://USER/INBOX#359561", isExternalAttachment:false, size:44083, sizeResolved:true, partID:"1.2"}) LookOut: Content Type: 'application/ms-tnef' LookOut: found tnef LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() TNEF Key: 2a73 checksum = 1 sum = 1 checksum = 232 sum = 232 TNEF: OEM Code Page = 1252 checksum = 1801 sum = 1801 checksum = 2 sum = 2 checksum = 357 sum = 357 2 checksum = 2097 sum = 2097 checksum = 2095 sum = 2095 checksum = 1801 sum = 1801 checksum = 40684 sum = 40684 TNEF: Entering tnef_file_notify() TNEF: Notifying listener of body_part_0.rtf, pos = 0, has data = true, is final = true LookOut: Entering onTnefStart() LookOut: body_part_0.rtf - 769 LookOut: adding attachment: imap://USER/fetch%3EUID%3E/INBOX%3E359561?part=1.2&filename=winmail.dat.1 LookOut: adding attachment: file:///tmp/lookout/body_part_0.rtf LookOut: Parent: [object Object] mMsgUri: imap-message://USER/INBOX#359561 requested Part_ID: 0 Part_ID: 1 Displayname: body_part_0.rtf Content-Type: application/rtf Length: 769 URL: file:///tmp/lookout/body_part_0.rtf mimeurl: imap://USER/fetch%3EUID%3E/INBOX%3E359561?part=1.2&filename=winmail.dat.1 LookOut: Entering add_sub_attachment_to_list() LookOut: content_type:application/rtf atturl:file:///tmp/lookout/body_part_0.rtf display_name:body_part_0.rtf msguri:imap-message://USER/INBOX#359561 LookOut: found new type object: AttachmentInfo LookOut: registered own function for attachment.open LookOut: registered own function for attachment.save Lookout: Entering redraw_attachment_view() LookOut: onTnefData position 0 data.len 769 outstrm [xpconnect wrapped nsIFileOutputStream] LookOut: writing 769bytes to file LookOut: Entering onTnefEnd() Lookout: Entering redraw_attachment_view() TNEF: VCF file is empty, Skipping checksum = 65 sum = 65 starting file sub-attachment checksum = 1199 sum = 1199 Lookout: convert file name from charset: WINDOWS-1252 checksum = 329 sum = 329 2 checksum = 27883 sum = 27883 LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() checksum = 22435 sum = 22435 checksum = 35679 sum = 35679 Lookout: convert file name from charset: WINDOWS-1252 TNEF: Entering tnef_file_notify() TNEF: Notifying listener of AASI PO# 20-008.pdf, pos = 0, has data = true, is final = true LookOut: Entering onTnefStart() LookOut: AASI PO# 20-008.pdf - 27430 LookOut: adding attachment: imap://USER/fetch%3EUID%3E/INBOX%3E359561?part=1.2&filename=winmail.dat.2 LookOut: adding attachment: file:///tmp/lookout/AASI%20PO%23%2020-008.pdf LookOut: Parent: [object Object] mMsgUri: imap-message://USER/INBOX#359561 requested Part_ID: 0 Part_ID: 2 Displayname: AASI PO# 20-008.pdf Content-Type: application/binary Length: 27430 URL: file:///tmp/lookout/AASI%20PO%23%2020-008.pdf mimeurl: imap://USER/fetch%3EUID%3E/INBOX%3E359561?part=1.2&filename=winmail.dat.2 LookOut: Entering add_sub_attachment_to_list() LookOut: content_type:application/binary atturl:file:///tmp/lookout/AASI%20PO%23%2020-008.pdf display_name:AASI PO# 20-008.pdf msguri:imap-message://USER/INBOX#359561 LookOut: found new type object: AttachmentInfo LookOut: registered own function for attachment.open LookOut: registered own function for attachment.save Lookout: Entering redraw_attachment_view() LookOut: onTnefData position 0 data.len 27430 outstrm [xpconnect wrapped nsIFileOutputStream] LookOut: writing 27430bytes to file LookOut: Entering onTnefEnd() Lookout: Entering redraw_attachment_view() LookOut: Entering onStopRequest() LookOut: Removing winmail.dat Lookout: Entering redraw_attachment_view() ```
NON WORKING DEBUG ```js LookOut: debug enabled LookOut: Entering on_end_all_attachments() LookOut: Entering scan_for_tnef() ({message:({}), contentType:"application/ms-tnef", name:"winmail.dat", url:"imap://USER/fetch%3EUID%3E/INBOX%3E228707?part=1.2&filename=winmail.dat", uri:"imap-message://USER/INBOX#228707", isExternalAttachment:false, size:44083, sizeResolved:true, partID:"1.2"}) LookOut: Content Type: 'application/ms-tnef' LookOut: found tnef LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() TNEF Key: 2a73 checksum = 1 sum = 1 checksum = 232 sum = 232 TNEF: OEM Code Page = 1252 checksum = 1801 sum = 1801 checksum = 2 sum = 2 checksum = 357 sum = 357 2 checksum = 2097 sum = 2097 checksum = 2095 sum = 2095 checksum = 1801 sum = 1801 checksum = 40684 sum = 40684 TNEF: Entering tnef_file_notify() TNEF: Notifying listener of body_part_0.rtf, pos = 0, has data = true, is final = true LookOut: Entering onTnefStart() LookOut: body_part_0.rtf - 769 LookOut: adding attachment: imap://USER/fetch%3EUID%3E/INBOX%3E228707?part=1.2&filename=winmail.dat.1 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.remove] lookout.js:369 LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 110100994 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 3584 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 256 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 536870912 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 8192 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 1090519040 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 2148532736 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 1310721 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 1094778880 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 1344293203 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 840966991 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 808463664 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 1685073464 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 78577766 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 58724866 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 3584 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 17294336 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 285216256 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 805309440 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 1224737280 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 2148729345 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 917507 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 132382720 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 917505 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 786449 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 131120 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 285344073 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 3087009408 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 16777229 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 2304 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 449539 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 553648128 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 6 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 1280 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 133376 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 83886080 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 16777216 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 4294967042 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 42240 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 3322626304 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 536905728 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 8192 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 536870912 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 8192 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 671088640 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 536870912 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 1073741824 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 16777216 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 256 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 0 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 1 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 0 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 0 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 0 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 0 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 4278190080 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 65535 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 0 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 0 Seems not to be a TNEF file LookOut: Entering onDataAvailable() TNEF: Entering tnef_pack_parse_stream() TNEF: new TnefPackage() sig = 0 Seems not to be a TNEF file LookOut: Entering onStopRequest() ```

dugite-code commented 4 years ago

Looks like you may have a slightly different issue to the original OP. I was afraid using the temporary files to get around the drag and drop issue might come back to haunt me.

The simplest solution would be to roll back the drag and drop changes. Unfortunately much has changed since then and can't be done auto-magically

dugite-code commented 4 years ago

I've published a release that removes the Temporary file creation reverting back to the old method -> v2.0.01b2

If you all could please test this. While I think @justmelly and (possibly) @erik2282 have a slightly different issue to @steosch they may share a root cause.

Please note: This breaks the ability to drag and drop files

GSNord commented 4 years ago

I just installed the new v2.0.01b2 The result is just the same like in my above post from Dec 17. I am still on TB 68.2.0 Seems I have a different problem than erik and justmelly with those verbose outputs in both working and non working cases. My output is still no more than the same 4 lines.

erik2282 commented 4 years ago

The new version does in fact open the winmail.dat. I will test on another system with another profile.

Update: worked on different system as well.

steosch commented 4 years ago

Doesn't work on my end I'm afraid (TB 68.5 64bit). Disabling "Content Type Matching" also did not help.

WebExtensions: Loading packed extension from C:\Users\steosch\AppData\Roaming\Thunderbird\Profiles\3od6ehct.default-release\extensions\lookout@s3_fix_version.xpi ext-legacy.js:157 WebExtensions: Loading add-on preferences from C:\Users\steosch\AppData\Roaming\Thunderbird\Profiles\3od6ehct.default-release\extensions\lookout@s3_fix_version.xpi ext-legacy.js:190 WebExtensions: Firing profile-after-change listeners for lookout@s3_fix_version ext-legacy.js:194 LookOut: debug enabled LookOut: Entering LookoutLoad() LookOut: Entering startup() LookOut: registering messageHeaderSink.onEndAllAttachments hook stylesheets actor: fetch failed for chrome://lookout/skin/overlay.css, using system principal instead. stylesheets.js:246:13 fetchStylesheet resource://devtools/server/actors/stylesheets.js:246

jtdawson3 commented 4 years ago

Do not know if this helps. If I view the message in the preview pane or open the message in a new tab winmail.dat is decoded and attachments are shown, but if I open the message in a new window Lookout fails to decode the winmail.dat file.

dugite-code commented 4 years ago

@jtdawson3 good catch, though I think this might be different to this issue. I've made a new issue here: https://github.com/TB-throwback/LookOut-fix-version/issues/57

steosch commented 4 years ago

Very good point -- thanx! This is actually how I have set it up over here. New messages are opened always in a new window, as I'm using the 'Folder Pane' Layout and mails are opened in a new window after a double-click.

Hope this helps, cheers, Stefan

dugite-code commented 4 years ago

Excellent, hopefully I'll be able to squash this bug now

GSNord commented 4 years ago

Thank you jtdawson3, I confirm winmail.dat gets decoded when opening mails in a new tab instead of a new window.

steosch commented 4 years ago

I can confirm, that the attachment is correctly decoded when opening the message in a tab. The same message opened in a window doesn't get decoded.

buchholz-lt commented 11 months ago

We have the use case to open .eml files from external source, so that display in own window is default. If you know a way to get them in a tab, let us know.

We noticed that in TB 115.4.0 there is no attachment shown while in TB 115.4.1 the winmail.dat is shown. Perhaps this helps to track this issue further. I'm using TB with Lookout 6.1 on Debian 12.

dugite-code commented 11 months ago

@buchholz-lt This issue is unlikely relevant to any issue you face due to a recent major amount or re-working done. Please open a separate issue.