search

TBD54566975 / didpay

Mobile app that provides a way for individuals to interact with PFIs via tbDEX
Apache License 2.0
6 stars 7 forks source link

feat: add request caching service (#280) #315

Open aashish-g03 opened 1 month ago

aashish-g03 commented 1 month ago

This PR adds request caching service with different customizable options.

Closes https://github.com/TBD54566975/didpay/issues/280.

ethan-tbd commented 1 month ago

as part of this pr, could you please include test cases to make sure that the request caching service works as intended!

aashish-g03 commented 1 month ago

@ethan-tbd I’ve added test cases for the service. Will this be considered part of the same task, or will I receive extra points for it?

ethan-tbd commented 1 month ago

Will this be considered part of the same task, or will I receive extra points for it?

I created a subissue https://github.com/TBD54566975/didpay/issues/318, make sure to be thorough with the test cases and try to follow the existing pattern for how we test Hive boxes!

taniashiba commented 1 month ago

Hi @aashish-g03 - could you please resolve the above comments so that @ethan-tbd may review/close your PR? Thank you!

taniashiba commented 3 weeks ago

Hi @aashish-g03 - If you'd like for your contribution here to count towards Hacktoberfest, please review the comments above so that @ethan-tbd may close and add the hacktoberfest-accepted label to your PR for you to earn points. If you need any help, let us know. ❤️

aashish-g03 commented 3 weeks ago

@taniashiba @ethan-tbd I've updated the service file according to your suggestions and included some suggestions at the end of service test file to enhance testing. Apologies for the delay—I experienced a sudden increase in office workload that limited my response time.