Closed LiranCohen closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.57%. Comparing base (
94da019
) to head (b00b990
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Do you think passing the message JSON directly for revocation creation is easier as dev-ex?
Yeah I was debating this, but wasn't sure which object the user would have more readily available so i opted with the parsed type.
I'll merge this in and we can improve it a bit in a subsequent PR. 🙏
In order to get Permission Revocation messages associated with a specific protocol from the
MessageStore
it is necessary for the revocation messages to be tagged with theprotocol
from the grant scope.In this PR:
protocol
property to thePermissionRevocationCreateOptions
which normalizes and adds the provided protocol as a tag.preProcessingForCoreRecordsWrite
method to theRecordsWriteHandler
where if the incoming message is a revocation message, the original grant will be fetched and the protocol tag from the revocation will be compared to the grant scope protocol.